chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java - Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java

Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer() (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorFetcherTest.java » ('j') | net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java

index 4e1777bbf31d4780ccf459dbed584ed6f4d5e8e2..2ca0c82ab415d1fd680cc2b4e848325a64a279b2 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java

@@ -8,7 +8,6 @@ import android.app.Activity;

import android.content.Context;

import android.content.Intent;

import android.graphics.Bitmap;

-import android.os.Environment;

import android.test.suitebuilder.annotation.SmallTest;

import org.chromium.base.ThreadUtils;

@@ -166,8 +165,7 @@ public class AddToHomescreenManagerTest extends ChromeActivityTestCaseBase<Chrom

public void setUp() throws Exception {

super.setUp();

ChromeWebApkHost.initForTesting(false);

- mTestServer = EmbeddedTestServer.createAndStartFileServer(

- getInstrumentation().getContext(), Environment.getExternalStorageDirectory());

+ mTestServer = EmbeddedTestServer.createAndStartServer(getInstrumentation().getContext());

// Register handler for "slow?10000" URL.

mTestServer.addDefaultHandlers(mTestServer.getURL("/chrome/test/data"));

mShortcutHelperDelegate = new TestShortcutHelperDelegate();