chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java - Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java

Issue 2431753003: Merge EmbeddedTestServer#createAndStartDefaultServer() and createAndStartFileServer() (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/video/FullscreenVideoTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/webapps/AddToHomescreenManagerTest.java » ('j') | net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java

index d82e969a4ee98b086641895775dc82922f0af127..625bca7b0d8cb8402846d096af2c93d5498bf5c3 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/video/VideoTest.java

@@ -4,7 +4,6 @@

package org.chromium.chrome.browser.video;

-import android.os.Environment;

import android.test.suitebuilder.annotation.LargeTest;

import org.chromium.base.test.util.DisableIf;

@@ -35,8 +34,8 @@ public class VideoTest extends ChromeActivityTestCaseBase<ChromeActivity> {

@LargeTest

@RetryOnFailure

public void testLoadMediaUrl() throws InterruptedException, TimeoutException {

- EmbeddedTestServer testServer = EmbeddedTestServer.createAndStartFileServer(

- getInstrumentation().getContext(), Environment.getExternalStorageDirectory());

+ EmbeddedTestServer testServer = EmbeddedTestServer.createAndStartServer(

+ getInstrumentation().getContext());

try {

Tab tab = getActivity().getActivityTab();

TabTitleObserver titleObserver = new TabTitleObserver(tab, "ready_to_play");