Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7584)

Unified Diff: blimp/client/public/resources/BUILD.gn

Issue 2431653004: Setup Blimp internal string resources. (Closed)
Patch Set: Removed unused entry in public/DEPS Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/public/resources/BUILD.gn
diff --git a/blimp/client/public/resources/BUILD.gn b/blimp/client/public/resources/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..983356e1da466bd4a35d2f9cfe6e70da1bac071d
--- /dev/null
+++ b/blimp/client/public/resources/BUILD.gn
@@ -0,0 +1,13 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Resources for the embedder, we build different resource sets based on |enable_blimp_client| build
+# flag in //blimp/client/core/resources.
+group("resources") {
+ visibility = [ "//chrome/*" ]
David Trainor- moved to gerrit 2016/10/26 00:43:18 Should we just remove the visibility if it's meant
xingliu 2016/10/26 21:14:42 Actually this target is only for chrome, because i
David Trainor- moved to gerrit 2016/10/28 04:20:08 Why is it only for chrome? We have to set enable_
xingliu 2016/10/28 22:50:31 Yes, but for blimp_shell it's directly depend on c
+
+ public_deps = [
+ "//blimp/client/core/resources:strings",
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698