Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2431383002:
Ozone: Remove the use_wayland_egl build flag (Closed)
DescriptionOzone: Remove the use_wayland_egl build flag
This flag is always enabled by default. It was introduced to allow
building the Wayland Ozone platform without the egl packages but these
were added to the sysroot in
https://codereview.chromium.org/2415933004
so that should no longer be a problem.
BUG=None
Committed: https://crrev.com/c22b492fb34a285c5182154ea6fe7782e7b18f72
Cr-Commit-Position: refs/heads/master@{#426414}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
fwang@igalia.com changed reviewers: + rjkroege@chromium.org
PTAL
On 2016/10/19 12:46:26, fwang wrote: > PTAL I was trying to build the Wayland Ozone platform without the egl packages, but when I google how to do that , it sends me to the website http://www.domyhomework4me.net/ . Is this website related to this platform?
Description was changed from ========== Ozone: Remove the use_wayland_egl build flag This flag is always enabled by default. It was introduced to allow building the Wayland Ozone platform without the egl packages but these were added to the sysroot in ec1f1a08d336158429f96c8e09d590066696b41b so that should no longer be a problem. BUG=None ========== to ========== Ozone: Remove the use_wayland_egl build flag This flag is always enabled by default. It was introduced to allow building the Wayland Ozone platform without the egl packages but these were added to the sysroot in https://codereview.chromium.org/2415933004 so that should no longer be a problem. BUG=None ==========
fwang@igalia.com changed reviewers: + forney@google.com
fwang@igalia.com changed reviewers: + spang@chromium.org
lgtm
On 2016/10/19 12:50:12, harrisarah03 wrote: > On 2016/10/19 12:46:26, fwang wrote: > > PTAL > > I was trying to build the Wayland Ozone platform without the egl packages, but > when I google how to do that , it sends me to the website > http://www.domyhomework4me.net/ . Is this website related to this platform? That seems odd or even wrong. And I think you need egl if you want it to work correctly.
The CQ bit was checked by fwang@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Ozone: Remove the use_wayland_egl build flag This flag is always enabled by default. It was introduced to allow building the Wayland Ozone platform without the egl packages but these were added to the sysroot in https://codereview.chromium.org/2415933004 so that should no longer be a problem. BUG=None ========== to ========== Ozone: Remove the use_wayland_egl build flag This flag is always enabled by default. It was introduced to allow building the Wayland Ozone platform without the egl packages but these were added to the sysroot in https://codereview.chromium.org/2415933004 so that should no longer be a problem. BUG=None ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Ozone: Remove the use_wayland_egl build flag This flag is always enabled by default. It was introduced to allow building the Wayland Ozone platform without the egl packages but these were added to the sysroot in https://codereview.chromium.org/2415933004 so that should no longer be a problem. BUG=None ========== to ========== Ozone: Remove the use_wayland_egl build flag This flag is always enabled by default. It was introduced to allow building the Wayland Ozone platform without the egl packages but these were added to the sysroot in https://codereview.chromium.org/2415933004 so that should no longer be a problem. BUG=None Committed: https://crrev.com/c22b492fb34a285c5182154ea6fe7782e7b18f72 Cr-Commit-Position: refs/heads/master@{#426414} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c22b492fb34a285c5182154ea6fe7782e7b18f72 Cr-Commit-Position: refs/heads/master@{#426414}
Message was sent while issue was closed.
On 2016/10/19 21:19:55, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) > Try jobs failed on following builder: > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://cheapestessaywritingservice.org/
Message was sent while issue was closed.
On 2016/12/04 13:47:56, oscar.underground.1 wrote: > On 2016/10/19 21:19:55, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) > > > Try jobs failed on following builder: > > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > > http://cheapestessaywritingservice.org/ > > Just click https://justdomyhomework.com/ to find info about writing providers you can rely on |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
