Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2415933004: Add Wayland dev packages to sysroots (Closed)

Created:
4 years, 2 months ago by Tom (Use chromium acct)
Modified:
4 years, 2 months ago
Reviewers:
rjkroege, Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Wayland dev packages to sysroots BUG=295089 R=dpranke@chromium.org Committed: https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b Cr-Commit-Position: refs/heads/master@{#425422}

Patch Set 1 #

Patch Set 2 : Add missing , #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -17 lines) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 1 1 chunk +12 lines, -12 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.amd64 View 2 chunks +8 lines, -1 line 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm View 2 chunks +8 lines, -1 line 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm64 View 2 chunks +8 lines, -1 line 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.i386 View 2 chunks +8 lines, -1 line 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.mipsel View 2 chunks +8 lines, -1 line 0 comments Download
M build/linux/sysroot_scripts/packagelist.precise.amd64 View 2 chunks +5 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.amd64 View 2 chunks +5 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.arm View 2 chunks +5 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.i386 View 2 chunks +5 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.mipsel View 2 chunks +5 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 2 chunks +7 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-precise.sh View 2 chunks +5 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Tom (Use chromium acct)
4 years, 2 months ago (2016-10-14 01:36:59 UTC) #5
Dirk Pranke
lgtm, but rjkroege@ should probably review this as well to see if the list looks ...
4 years, 2 months ago (2016-10-14 01:40:29 UTC) #7
rjkroege
lgtm.
4 years, 2 months ago (2016-10-14 19:08:36 UTC) #14
Tom (Use chromium acct)
4 years, 2 months ago (2016-10-14 19:11:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2415933004/20001
4 years, 2 months ago (2016-10-14 19:11:54 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 19:20:37 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 19:21:59 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ec1f1a08d336158429f96c8e09d590066696b41b
Cr-Commit-Position: refs/heads/master@{#425422}

Powered by Google App Engine
This is Rietveld 408576698