Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: tests/compiler/dart2js/sourcemaps/diff_view.dart

Issue 2431223006: Add stacktrace_test (Closed)
Patch Set: Updated cf. comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/io/position_information.dart ('k') | tests/compiler/dart2js/sourcemaps/lax_json.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/sourcemaps/diff_view.dart
diff --git a/tests/compiler/dart2js/sourcemaps/diff_view.dart b/tests/compiler/dart2js/sourcemaps/diff_view.dart
index bd29b49f3b3731f042e59b27bb85c17381cff10f..db07f93c0619af5e65993911c3b1353c0722b36b 100644
--- a/tests/compiler/dart2js/sourcemaps/diff_view.dart
+++ b/tests/compiler/dart2js/sourcemaps/diff_view.dart
@@ -69,9 +69,8 @@ main(List<String> args) async {
// deleted.
// Use default options; comparing SSA and CPS output using the new
// source information strategy.
+ options.add(commonArguments);
options.add([Flags.useNewSourceInfo]..addAll(commonArguments));
- options.add([Flags.useNewSourceInfo]..addAll(commonArguments));
- throw "missing options: please specify options for the second column";
} else if (optionSegments.length == 2) {
// Use alternative options for the second output column.
options.add(commonArguments);
@@ -793,7 +792,7 @@ Future<CodeLinesResult> computeCodeLines(
if (!added) {
int offset;
if (options.contains(Flags.useNewSourceInfo)) {
- offset = step.offset.subexpressionOffset;
+ offset = step.offset.value;
} else {
offset = info.jsCodePositions[step.node].startPosition;
}
« no previous file with comments | « pkg/compiler/lib/src/io/position_information.dart ('k') | tests/compiler/dart2js/sourcemaps/lax_json.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698