Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: pkg/compiler/lib/src/io/position_information.dart

Issue 2431223006: Add stacktrace_test (Closed)
Patch Set: Updated cf. comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/dart2js.dart ('k') | tests/compiler/dart2js/sourcemaps/diff_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/io/position_information.dart
diff --git a/pkg/compiler/lib/src/io/position_information.dart b/pkg/compiler/lib/src/io/position_information.dart
index b4a764fc53b09cbef9eca8cd050a2030db2cb569..cfb6657aea7e777ac563509e50eb70c664c00663 100644
--- a/pkg/compiler/lib/src/io/position_information.dart
+++ b/pkg/compiler/lib/src/io/position_information.dart
@@ -522,7 +522,7 @@ class PositionTraceListener extends TraceListener
void onStep(js.Node node, Offset offset, StepKind kind) {
SourceInformation sourceInformation = computeSourceInformation(node);
if (sourceInformation == null) return;
- int codeLocation = offset.subexpressionOffset;
+ int codeLocation = offset.value;
if (codeLocation == null) return;
void registerPosition(SourcePositionKind sourcePositionKind) {
@@ -676,6 +676,8 @@ class Offset {
Offset(
this.statementOffset, this.leftToRightOffset, this.subexpressionOffset);
+ int get value => subexpressionOffset;
+
String toString() {
return 'Offset[statementOffset=$statementOffset,'
'leftToRightOffset=$leftToRightOffset,'
« no previous file with comments | « pkg/compiler/lib/src/dart2js.dart ('k') | tests/compiler/dart2js/sourcemaps/diff_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698