Revert of Use FileDescriptorWatcher in wl::FakeServer. (patchset #1 id:1 of https://codereview.chro…

Revert of Use FileDescriptorWatcher in wl::FakeServer. (patchset #1 id:1 of https://codereview.chromium.org/2397803002)

Reason for revert: There is no bots that build/run ozone/wayland
unit tests at the moment, although it is being worked on in
https://codereview.chromium.org/2423833002/.

This CL caused a build failure in Wayland unit tests, see
https://codereview.chromium.org/2434723002/. It also made them fail.

One can run them with GN args

  dcheck_always_on = true
    is_debug = false
      symbol_level = 1

  target_os = "chromeos"
    use_ozone = true
      ozone_platform_wayland = true

$ ninja time ninja -C <out> wayland_unittests  ozone_unittests
$ <out>/ozone_unittests

Failure:

[1019/104135:ERROR:kill_posix.cc(84)] Unable to terminate process group 19687:
No such process
[ RUN      ] WaylandConnectionTest.UseUnstableVersion
[19687:19687:1019/104135:94999256539:FATAL:file_descriptor_watcher_posix.cc(29)]
Check failed: sequence_checker_.CalledOnValidSequence().

Committed: https://crrev.com/91e00f4a950a17ce6c0d055aad37d9c4c16e152c
Cr-Commit-Position: refs/heads/master@{#426209}

[fwang, 2016-10-19 15:33:03]

fwang@igalia.com changed reviewers:
+ spang@chromium.org

[spang, 2016-10-19 15:33:50]

The CQ bit was checked by spang@chromium.org

[spang, 2016-10-19 15:33:51]

lgtm

[commit-bot: I haz the power, 2016-10-19 15:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 16:00:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-21 13:08:58]

Description was changed from

==========
Revert of Use FileDescriptorWatcher in wl::FakeServer. (patchset #1 id:1 of
https://codereview.chromium.org/2397803002)

Reason for revert: There is no bots that build/run ozone/wayland
unit tests at the moment, although it is being worked on in
https://codereview.chromium.org/2423833002/.

This CL caused a build failure in Wayland unit tests, see
https://codereview.chromium.org/2434723002/. It also made them fail.

One can run them with GN args

  dcheck_always_on = true
    is_debug = false
      symbol_level = 1

  target_os = "chromeos"
    use_ozone = true
      ozone_platform_wayland = true

$ ninja time ninja -C <out> wayland_unittests  ozone_unittests
$ <out>/ozone_unittests

Failure:

[1019/104135:ERROR:kill_posix.cc(84)] Unable to terminate process group 19687:
No such process
[ RUN      ] WaylandConnectionTest.UseUnstableVersion
[19687:19687:1019/104135:94999256539:FATAL:file_descriptor_watcher_posix.cc(29)]
Check failed: sequence_checker_.CalledOnValidSequence().
==========

to

==========
Revert of Use FileDescriptorWatcher in wl::FakeServer. (patchset #1 id:1 of
https://codereview.chromium.org/2397803002)

Reason for revert: There is no bots that build/run ozone/wayland
unit tests at the moment, although it is being worked on in
https://codereview.chromium.org/2423833002/.

This CL caused a build failure in Wayland unit tests, see
https://codereview.chromium.org/2434723002/. It also made them fail.

One can run them with GN args

  dcheck_always_on = true
    is_debug = false
      symbol_level = 1

  target_os = "chromeos"
    use_ozone = true
      ozone_platform_wayland = true

$ ninja time ninja -C <out> wayland_unittests  ozone_unittests
$ <out>/ozone_unittests

Failure:

[1019/104135:ERROR:kill_posix.cc(84)] Unable to terminate process group 19687:
No such process
[ RUN      ] WaylandConnectionTest.UseUnstableVersion
[19687:19687:1019/104135:94999256539:FATAL:file_descriptor_watcher_posix.cc(29)]
Check failed: sequence_checker_.CalledOnValidSequence().

Committed: https://crrev.com/91e00f4a950a17ce6c0d055aad37d9c4c16e152c
Cr-Commit-Position: refs/heads/master@{#426209}
==========

[commit-bot: I haz the power, 2016-10-21 13:08:58]

Patchset 1 (id:??) landed as
https://crrev.com/91e00f4a950a17ce6c0d055aad37d9c4c16e152c
Cr-Commit-Position: refs/heads/master@{#426209}