Use FileDescriptorWatcher in wl::FakeServer.

Use FileDescriptorWatcher in wl::FakeServer.

FileDescriptorWatcher is a new API that replaces
MessageLoopForIO::WatchFileDescriptor.

BUG=645114
Committed: https://crrev.com/233655edccc560d98e739b48f16879df99d9c398
Cr-Commit-Position: refs/heads/master@{#425685}

[fdoray, 2016-10-05 15:41:03]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 15:41:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 15:50:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 15:50:52]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-10-05 17:01:48]

fdoray@chromium.org changed reviewers:
+ spang@chromium.org

[fdoray, 2016-10-05 17:01:48]

PTAL

[fdoray, 2016-10-11 12:34:46]

Is there a bot on which I can run wayland_unittests?

[spang, 2016-10-11 16:57:41]

On 2016/10/11 12:34:46, fdoray wrote:
> Is there a bot on which I can run wayland_unittests?

lgtm

Not yet:

gn gen out_gn_ozone --args='target_os="chromeos" is_debug=false use_goma=true
use_ozone=true ozone_platform_headless=true ozone_platform_wayland=true
ozone_platform_caca=true is_component_build=true use_sysroot=false'

./out_gn_ozone/ozone_unittests

[68/88] WaylandConnectionTest.UseUnstableVersion (0 ms)
[69/88] WaylandConnectionTest.Ping (1 ms)
[70/88] WaylandConnectionTest.Output (0 ms)
[71/88] WaylandPointerTest.Leave (1 ms)
[72/88] WaylandPointerTest.Motion (1 ms)
[73/88] WaylandPointerTest.MotionDragged (0 ms)
[74/88] WaylandPointerTest.ButtonPress (1 ms)
[75/88] WaylandPointerTest.ButtonRelease (0 ms)
[76/88] WaylandPointerTest.AxisVertical (1 ms)
[77/88] WaylandPointerTest.AxisHorizontal (0 ms)
[78/88] WaylandSurfaceFactoryTest.Canvas (1 ms)
[79/88] WaylandSurfaceFactoryTest.CanvasResize (1 ms)
[80/88] WaylandWindowTest.SetTitle (0 ms)
[81/88] WaylandWindowTest.Maximize (1 ms)
[82/88] WaylandWindowTest.Minimize (1 ms)
[83/88] WaylandWindowTest.Restore (0 ms)
[84/88] WaylandWindowTest.CanDispatchMouseEventDefault (0 ms)
[85/88] WaylandWindowTest.CanDispatchMouseEventFocus (1 ms)
[86/88] WaylandWindowTest.CanDispatchMouseEventUnfocus (0 ms)
[87/88] WaylandWindowTest.DispatchEvent (1 ms)
[88/88] WaylandWindowTest.ConfigureEvent (0 ms)

[fdoray, 2016-10-11 17:05:33]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-10-11 17:05:41]

The CQ bit was unchecked by fdoray@chromium.org

[fdoray, 2016-10-17 15:26:05]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-10-17 15:26:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 15:35:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-17 15:39:23]

Description was changed from

==========
Use FileDescriptorWatcher in wl::FakeServer.

FileDescriptorWatcher is a new API that replaces
MessageLoopForIO::WatchFileDescriptor.

BUG=645114
==========

to

==========
Use FileDescriptorWatcher in wl::FakeServer.

FileDescriptorWatcher is a new API that replaces
MessageLoopForIO::WatchFileDescriptor.

BUG=645114

Committed: https://crrev.com/233655edccc560d98e739b48f16879df99d9c398
Cr-Commit-Position: refs/heads/master@{#425685}
==========

[commit-bot: I haz the power, 2016-10-17 15:39:24]

Patchset 1 (id:??) landed as
https://crrev.com/233655edccc560d98e739b48f16879df99d9c398
Cr-Commit-Position: refs/heads/master@{#425685}

[tonikitoo, 2016-10-19 14:42:45]

On 2016/10/11 12:34:46, fdoray wrote:
> Is there a bot on which I can run wayland_unittests?

There is no bot, but this change actually broke all wayland_unittests.

you can run them with GN args

  dcheck_always_on = true
  is_debug = false
  symbol_level = 1

  target_os = "chromeos"
  use_ozone = true
  ozone_platform_wayland = true

$ ninja time ninja -C <out> wayland_unittests  ozone_unittests
$ <out>/ozone_unittests

Failure:

IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 8 parallel jobs.
[1019/104135:ERROR:kill_posix.cc(84)] Unable to terminate process group 19687:
No such process
[ RUN      ] WaylandConnectionTest.UseUnstableVersion
[19687:19687:1019/104135:94999256539:FATAL:file_descriptor_watcher_posix.cc(29)]
Check failed: sequence_checker_.CalledOnValidSequence(). 
#0 0x7f6fa9aae91e base::debug::StackTrace::StackTrace()
#1 0x7f6fa9ad0940 logging::LogMessage::~LogMessage()
#2 0x7f6fa9ab2bde base::FileDescriptorWatcher::Controller::~Controller()
#3 0x000000418d22 wl::FakeServer::~FakeServer()
#4 0x00000042c56c ui::WaylandConnectionTest_UseUnstableVersion_Test::TestBody()
#5 0x00000045b787 testing::Test::Run()
#6 0x00000045c309 testing::TestInfo::Run()
#7 0x00000045c8e7 testing::TestCase::Run()
#8 0x000000462ab7 testing::internal::UnitTestImpl::RunAllTests()
#9 0x0000004626f7 testing::UnitTest::Run()
#10 0x00000044191d base::TestSuite::Run()
#11 0x000000442d99 base::(anonymous namespace)::LaunchUnitTestsInternal()
#12 0x000000442c64 base::LaunchUnitTests()
#13 0x000000417f2f main
#14 0x7f6fa7a06731 __libc_start_main
#15 0x000000417dc9 _start

[1/21] WaylandConnectionTest.UseUnstableVersion (CRASHED)
(...)

[not to use - tonikitoo, 2016-10-19 14:59:38]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2437563004/ by tonikitoo@chromium.org.

The reason for reverting is: There is no bots that build/run ozone/wayland unit
tests at the moment, although it is being worked on in
https://codereview.chromium.org/2423833002/.

This CL has made all wayland unit tests to fail:

One can run them with GN args

  dcheck_always_on = true
  is_debug = false
  symbol_level = 1

  target_os = "chromeos"
  use_ozone = true
  ozone_platform_wayland = true

$ ninja time ninja -C <out> wayland_unittests  ozone_unittests
$ <out>/ozone_unittests

Failure:

[1019/104135:ERROR:kill_posix.cc(84)] Unable to terminate process group 19687:
No such process
[ RUN      ] WaylandConnectionTest.UseUnstableVersion
[19687:19687:1019/104135:94999256539:FATAL:file_descriptor_watcher_posix.cc(29)]
Check failed: sequence_checker_.CalledOnValidSequence(). 
#0 0x7f6fa9aae91e base::debug::StackTrace::StackTrace()
#1 0x7f6fa9ad0940 logging::LogMessage::~LogMessage()
#2 0x7f6fa9ab2bde base::FileDescriptorWatcher::Controller::~Controller()
#3 0x000000418d22 wl::FakeServer::~FakeServer()
#4 0x00000042c56c ui::WaylandConnectionTest_UseUnstableVersion_Test::TestBody()
#5 0x00000045b787 testing::Test::Run()
#6 0x00000045c309 testing::TestInfo::Run()
#7 0x00000045c8e7 testing::TestCase::Run()
#8 0x000000462ab7 testing::internal::UnitTestImpl::RunAllTests()
#9 0x0000004626f7 testing::UnitTest::Run()
#10 0x00000044191d base::TestSuite::Run()
#11 0x000000442d99 base::(anonymous namespace)::LaunchUnitTestsInternal()
#12 0x000000442c64 base::LaunchUnitTests()
#13 0x000000417f2f main
#14 0x7f6fa7a06731 __libc_start_main
#15 0x000000417dc9 _start.