fix #27532, implementing a native type with fields

fix #27532, implementing a native type with fields

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/cc1ad8cdde8dd31cb7a1e15930ff799f646afd5c

[Jennifer Messerly, 2016-10-20 22:30:27]

jmesserly@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-10-20 22:46:41]

https://codereview.chromium.org/2430953006/diff/1/pkg/dev_compiler/lib/js/amd...
File pkg/dev_compiler/lib/js/amd/dart_sdk.js (right):

https://codereview.chromium.org/2430953006/diff/1/pkg/dev_compiler/lib/js/amd...
pkg/dev_compiler/lib/js/amd/dart_sdk.js:37588: +        super.left = value;
Doesn't appear to be a setter in the supertype.  Not sure why this is generated.
 Seems like _emitSuperAccessorWrapper should not emit this if no setter was
found.

[Jennifer Messerly, 2016-10-20 22:54:20]

https://codereview.chromium.org/2430953006/diff/1/pkg/dev_compiler/lib/js/amd...
File pkg/dev_compiler/lib/js/amd/dart_sdk.js (right):

https://codereview.chromium.org/2430953006/diff/1/pkg/dev_compiler/lib/js/amd...
pkg/dev_compiler/lib/js/amd/dart_sdk.js:37588: +        super.left = value;
On 2016/10/20 22:46:41, vsm wrote:
> Doesn't appear to be a setter in the supertype.  Not sure why this is
generated.
>  Seems like _emitSuperAccessorWrapper should not emit this if no setter was
> found.

_emitVirtualFieldAccessor does this always. I don't know the history, it seems
it was added in
https://github.com/dart-lang/sdk/commit/6a7e3ca102e93e7ff7f5c33a7ed6136e486fa652.
My guess is that it's harmless; you'll get the same error you would've gotten if
you try and set the field. I'm happy to add a TODO but I didn't change that
code, so I'd prefer to unblock Kevin and not dig in now.

[vsm, 2016-10-20 22:57:15]

lgtm

[Jennifer Messerly, 2016-10-20 22:59:25]

Description was changed from

==========
fix #27532, implementing a native type with fields
==========

to

==========
fix #27532, implementing a native type with fields

R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/cc1ad8cdde8dd31cb7a1e15930ff...
==========

[Jennifer Messerly, 2016-10-20 22:59:29]

Committed patchset #1 (id:1) manually as
cc1ad8cdde8dd31cb7a1e15930ff799f646afd5c (presubmit successful).