Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart

Issue 2430953006: fix #27532, implementing a native type with fields (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart
diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart
index f6b12eb4e177eac173181c6cf0b940a1c307368c..87ed08b8be5d1f2e588da66be9c372c3a37a7f5b 100644
--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart
+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart
@@ -459,11 +459,6 @@ defineExtensionMembers(type, methodNames) => JS(
let proto = $type.prototype;
for (let name of $methodNames) {
let method = $getOwnPropertyDescriptor(proto, name);
- // TODO(vsm): We should be able to generate code to avoid this case.
- // The method may be null if this type implements a potentially native
- // interface but isn't native itself. For a field on this type, we're not
- // generating a corresponding getter/setter method - it's just a field.
- if (!method) continue;
$defineProperty(proto, $getExtensionSymbol(name), method);
}
// Ensure the signature is available too.

Powered by Google App Engine
This is Rietveld 408576698