Issue 2430823002: Reduce usage of FOR_EACH_OBSERVER macro in components/

Issue 2430823002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers

Modified:
4 years, 2 months ago

Reviewers:
sdefresne

CC:
chromium-reviews, asvitkine+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Reduce usage of FOR_EACH_OBSERVER macro in components/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458 Cr-Commit-Position: refs/heads/master@{#426099}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -48 lines)			Patch
M	components/renderer_context_menu/render_view_context_menu_base.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	components/search_engines/template_url_service.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/search_provider_logos/logo_tracker.cc	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	components/sessions/core/tab_restore_service_helper.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	components/syncable_prefs/pref_model_associator.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/syncable_prefs/pref_service_syncable.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/undo/undo_manager.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/update_client/update_client.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	components/user_prefs/tracked/segregated_pref_store.cc	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	components/variations/service/variations_service.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	components/wallpaper/wallpaper_manager_base.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	components/wallpaper/wallpaper_resizer.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	components/zoom/zoom_controller.cc	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	components/zoom/zoom_event_manager.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 11 (6 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430823002/1

4 years, 2 months ago (2016-10-18 23:39:07 UTC) #8

commit-bot: I haz the power

4 years, 2 months ago (2016-10-21 13:05:11 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ff2af33b552b7a319cc81cb26906064578182458
Cr-Commit-Position: refs/heads/master@{#426099}