Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: components/search_provider_logos/logo_tracker.cc

Issue 2430823002: Reduce usage of FOR_EACH_OBSERVER macro in components/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_provider_logos/logo_tracker.cc
diff --git a/components/search_provider_logos/logo_tracker.cc b/components/search_provider_logos/logo_tracker.cc
index 2027d8ab50002e3bf759c559351f335dfc7088ba..0facd9814fdad236045252733bce7745c02a8722 100644
--- a/components/search_provider_logos/logo_tracker.cc
+++ b/components/search_provider_logos/logo_tracker.cc
@@ -157,7 +157,8 @@ void LogoTracker::ReturnToIdle(int outcome) {
is_cached_logo_valid_ = false;
// Clear obsevers.
- FOR_EACH_OBSERVER(LogoObserver, logo_observers_, OnObserverRemoved());
+ for (auto& observer : logo_observers_)
+ observer.OnObserverRemoved();
logo_observers_.Clear();
}
@@ -186,7 +187,8 @@ void LogoTracker::OnCachedLogoAvailable(const LogoMetadata& metadata,
}
is_cached_logo_valid_ = true;
Logo* logo = cached_logo_.get();
- FOR_EACH_OBSERVER(LogoObserver, logo_observers_, OnLogoAvailable(logo, true));
+ for (auto& observer : logo_observers_)
+ observer.OnLogoAvailable(logo, true);
FetchLogo();
}
@@ -294,9 +296,8 @@ void LogoTracker::OnFreshLogoAvailable(
// Notify observers if a new logo was fetched, or if the new logo is NULL
// but the cached logo was non-NULL.
if (logo || cached_logo_) {
- FOR_EACH_OBSERVER(LogoObserver,
- logo_observers_,
- OnLogoAvailable(logo.get(), false));
+ for (auto& observer : logo_observers_)
+ observer.OnLogoAvailable(logo.get(), false);
SetCachedLogo(std::move(encoded_logo));
}
}
« no previous file with comments | « components/search_engines/template_url_service.cc ('k') | components/sessions/core/tab_restore_service_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698