[Mac] Fix rough-looking profile picker text, especially with a dark theme.

chrome/browser/ui/cocoa/tabs/tab_strip_background_view_private.h

Index: chrome/browser/ui/cocoa/tabs/tab_strip_background_view_private.h
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_background_view_private.h b/chrome/browser/ui/cocoa/tabs/tab_strip_background_view_private.h
new file mode 100644
index 0000000000000000000000000000000000000000..87a6f5554fe5a776135794a8505cd81f06e1c298
--- /dev/null
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_background_view_private.h
@@ -0,0 +1,23 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_PRIVATE_H_

[Robert Sesek, 2017/01/11 19:23:40]

Not sure I understand the point of this file.

[Sidney San Martín, 2017/01/11 22:00:58]

It's so that tab_strip_background_view_unittest.mm has access to private details
like <ThemedWindowDrawing> protocol conformance. Maybe it should be named
…_testing.h? I'd love to get rid of it if there's a better way.

[Robert Sesek, 2017/01/11 22:09:54]

I think I view that as a public detail (it's certainly public for all existing
conformers).

+#define CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_PRIVATE_H_
+
+#include "chrome/browser/ui/cocoa/tabs/tab_strip_background_view.h"
+
+#import "chrome/browser/ui/cocoa/themed_window.h"
+
+@class NSVisualEffectView;
+extern NSString* const NSAppearanceNameVibrantDark;

[Robert Sesek, 2017/01/11 19:23:40]

Why did these get moved out of sdk_forward_declarations.h?

+extern NSString* const NSAppearanceNameVibrantLight;
+
+@interface NSAppearance (AllowsVibrancy)
+@property(readonly) BOOL allowsVibrancy;
+@end
+
+@interface TabStripBackgroundView ()<ThemedWindowDrawing>
+@end
+
+#endif  // CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_PRIVATE_H_