chrome/browser/ui/cocoa/tabs/tab_strip_background_view_private.h - Issue 2430493002: [Mac] Fix rough-looking profile picker text, especially with a dark theme.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_strip_background_view_private.h

Issue 2430493002: [Mac] Fix rough-looking profile picker text, especially with a dark theme. (Closed)

Patch Set: Add theme tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/cocoa/tabs/tab_strip_background_view.mm ('K') | « chrome/browser/ui/cocoa/tabs/tab_strip_background_view.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_background_view_unittest.mm » ('j') | chrome/browser/ui/cocoa/tabs/tab_strip_background_view_unittest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_PRIVATE_H_
	Robert Sesek 2017/01/11 19:23:40 Not sure I understand the point of this file. Not sure I understand the point of this file. Sidney San Martín 2017/01/11 22:00:58 It's so that tab_strip_background_view_unittest.mm Show quoted text On 2017/01/11 19:23:40, Robert Sesek wrote: > Not sure I understand the point of this file. It's so that tab_strip_background_view_unittest.mm has access to private details like <ThemedWindowDrawing> protocol conformance. Maybe it should be named …_testing.h? I'd love to get rid of it if there's a better way. Robert Sesek 2017/01/11 22:09:54 I think I view that as a public detail (it's certa Show quoted text On 2017/01/11 22:00:58, sdy wrote: > On 2017/01/11 19:23:40, Robert Sesek wrote: > > Not sure I understand the point of this file. > > It's so that tab_strip_background_view_unittest.mm has access to private details > like <ThemedWindowDrawing> protocol conformance. Maybe it should be named > …_testing.h? I'd love to get rid of it if there's a better way. I think I view that as a public detail (it's certainly public for all existing conformers).
	6 #define CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_PRIVATE_H_

	7

	8 #include "chrome/browser/ui/cocoa/tabs/tab_strip_background_view.h"

	9

	10 #import "chrome/browser/ui/cocoa/themed_window.h"

	11

	12 @class NSVisualEffectView;

	13 extern NSString* const NSAppearanceNameVibrantDark;
	Robert Sesek 2017/01/11 19:23:40 Why did these get moved out of sdk_forward_declara Why did these get moved out of sdk_forward_declarations.h?
	14 extern NSString* const NSAppearanceNameVibrantLight;

	15

	16 @interface NSAppearance (AllowsVibrancy)

	17 @property(readonly) BOOL allowsVibrancy;

	18 @end

	19

	20 @interface TabStripBackgroundView ()<ThemedWindowDrawing>

	21 @end

	22

	23 #endif // CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_PRIVATE_H_

OLD	NEW