Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 24304003: Clear the usage of useBrowserOverlays from WebFrame/Impl and ChromePrintContext (Closed)

Created:
7 years, 3 months ago by vivekg_samsung
Modified:
7 years, 3 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Clear the usage of useBrowserOverlays from WebFrame/Impl and ChromePrintContext As per https://codereview.chromium.org/11953010/, chromium is no longer using the useBrowserOverlays. Also the bug https://bugs.webkit.org/show_bug.cgi?id=107718 marks the removal of the same. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M Source/web/WebFrameImpl.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/web/WebFrameImpl.cpp View 4 chunks +1 line, -13 lines 0 comments Download
M public/web/WebFrame.h View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vivekg__
Chromium side changes: https://codereview.chromium.org/23835016/
7 years, 3 months ago (2013-09-20 01:17:32 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 3 months ago (2013-09-20 04:46:23 UTC) #2
jamesr
I still see several callers on the chromium side that specify the last parameter, so ...
7 years, 3 months ago (2013-09-20 04:49:29 UTC) #3
vivekg__
On 2013/09/20 04:49:29, jamesr wrote: > I still see several callers on the chromium side ...
7 years, 3 months ago (2013-09-20 05:14:46 UTC) #4
jamesr
Those were the ones I found too. lgtm
7 years, 3 months ago (2013-09-20 05:30:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/24304003/1
7 years, 3 months ago (2013-09-20 05:33:51 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-20 07:00:40 UTC) #7
Message was sent while issue was closed.
Change committed as 158087

Powered by Google App Engine
This is Rietveld 408576698