Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 24304003: Clear the usage of useBrowserOverlays from WebFrame/Impl and ChromePrintContext (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebFrameImpl.h ('k') | public/web/WebFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebFrameImpl.cpp
diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp
index 2ae352a784a8bc2189f986afa5872da269e86052..180d545546820aa2b9ba739002a49c377cff5a84 100644
--- a/Source/web/WebFrameImpl.cpp
+++ b/Source/web/WebFrameImpl.cpp
@@ -403,11 +403,6 @@ public:
return PrintContext::pageCount();
}
- virtual bool shouldUseBrowserOverlays() const
- {
- return true;
- }
-
private:
// Set when printing.
float m_printedPageWidth;
@@ -460,11 +455,6 @@ public:
return 1.0;
}
- virtual bool shouldUseBrowserOverlays() const
- {
- return false;
- }
-
private:
// Set when printing.
WebPluginContainerImpl* m_plugin;
@@ -1379,7 +1369,7 @@ VisiblePosition WebFrameImpl::visiblePositionForWindowPoint(const WebPoint& poin
return VisiblePosition();
}
-int WebFrameImpl::printBegin(const WebPrintParams& printParams, const WebNode& constrainToNode, bool* useBrowserOverlays)
+int WebFrameImpl::printBegin(const WebPrintParams& printParams, const WebNode& constrainToNode)
{
ASSERT(!frame()->document()->isFrameSet());
WebPluginContainerImpl* pluginContainer = 0;
@@ -1403,8 +1393,6 @@ int WebFrameImpl::printBegin(const WebPrintParams& printParams, const WebNode& c
// We ignore the overlays calculation for now since they are generated in the
// browser. pageHeight is actually an output parameter.
m_printContext->computePageRects(rect, 0, 0, 1.0, pageHeight);
- if (useBrowserOverlays)
- *useBrowserOverlays = m_printContext->shouldUseBrowserOverlays();
return m_printContext->pageCount();
}
« no previous file with comments | « Source/web/WebFrameImpl.h ('k') | public/web/WebFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698