Chromium Code Reviews| Index: scripts/slave/recipe_modules/chromium/config.py |
| diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py |
| index 2c340bf30bd89db9b20eefd0bc299180a3a28485..5bfbb991e26e0f21c6d19b9a5cda87f6086b5c4d 100644 |
| --- a/scripts/slave/recipe_modules/chromium/config.py |
| +++ b/scripts/slave/recipe_modules/chromium/config.py |
| @@ -19,7 +19,7 @@ HOST_ARCHS = ('intel',) |
| TARGET_ARCHS = HOST_ARCHS + ('arm', 'mips', 'mipsel') |
| TARGET_CROS_BOARDS = (None, 'x86-generic') |
| BUILD_CONFIGS = ('Release', 'Debug', 'Coverage') |
| -MEMORY_TOOLS = ('memcheck', 'drmemory_full', 'drmemory_light') |
| +MEMORY_TOOLS = ('memcheck',) |
|
kjellander_chromium
2016/10/19 14:09:18
Can you remove this now? I think we can use an ena
|
| PROJECT_GENERATORS = ('gyp', 'gn', 'mb') |
| def check(val, potentials): |
| @@ -483,16 +483,6 @@ def syzyasan(c): |
| gyp_defs['win_z7'] = 1 |
| gyp_defs['chromium_win_pch'] = 0 |
| -@config_ctx(group='memory_tool') |
| -def drmemory_full(c): |
| - _memory_tool(c, 'drmemory_full') |
| - c.gyp_env.GYP_DEFINES['build_for_tool'] = 'drmemory' |
| - |
| -@config_ctx(group='memory_tool') |
| -def drmemory_light(c): |
| - _memory_tool(c, 'drmemory_light') |
| - c.gyp_env.GYP_DEFINES['build_for_tool'] = 'drmemory' |
| - |
| def _memory_tool(c, tool): |
|
kjellander_chromium
2016/10/19 14:09:18
I suggest we can remove this too.
|
| if tool not in MEMORY_TOOLS: # pragma: no cover |
| raise BadConf('"%s" is not a supported memory tool, the supported ones ' |