WebRTC: Remove Dr Memory bots.

scripts/slave/recipe_modules/chromium/config.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import pipes
 
 from recipe_engine.config import config_item_context, ConfigGroup
 from recipe_engine.config import Dict, List, Single, Static, Set, BadConf
 from recipe_engine.config_types import Path
 
 # Because of the way that we use decorators, pylint can't figure out the proper
 # type signature of functions annotated with the @config_ctx decorator.
 # pylint: disable=E1123
 
 HOST_PLATFORMS = ('linux', 'win', 'mac')
 TARGET_PLATFORMS = HOST_PLATFORMS + ('ios', 'android', 'chromeos')
 HOST_TARGET_BITS = (32, 64)
 HOST_ARCHS = ('intel',)
 TARGET_ARCHS = HOST_ARCHS + ('arm', 'mips', 'mipsel')
 TARGET_CROS_BOARDS = (None, 'x86-generic')
 BUILD_CONFIGS = ('Release', 'Debug', 'Coverage')
-MEMORY_TOOLS = ('memcheck', 'drmemory_full', 'drmemory_light')
+MEMORY_TOOLS = ('memcheck',)

[kjellander_chromium, 2016/10/19 14:09:18]

Can you remove this now? I think we can use an enable_memcheck variable instead.

 PROJECT_GENERATORS = ('gyp', 'gn', 'mb')
 
 def check(val, potentials):
   assert val in potentials, (val, potentials)
   return val
 
 # Schema for config items in this module.
 def BaseConfig(HOST_PLATFORM, HOST_ARCH, HOST_BITS,
                TARGET_PLATFORM, TARGET_ARCH, TARGET_BITS,
                BUILD_CONFIG, TARGET_CROS_BOARD,
@@ skipping 42 matching lines @@
     project_generator = ConfigGroup(
       tool = Single(basestring, empty_val='gyp'),
       args = Set(basestring),
     ),
     build_dir = Single(Path),
     cros_sdk = ConfigGroup(
       external = Single(bool, empty_val=True, required=False),
       args = List(basestring),
     ),
     runtests = ConfigGroup(
       memory_tool = Single(basestring, required=False),

[kjellander_chromium, 2016/10/19 14:09:18]

can you refactor this to:
enable_memcheck = Single(bool, empty_val=False, required=False),
?

       memory_tests_runner = Single(Path),
       enable_lsan = Single(bool, empty_val=False, required=False),
       test_args = List(basestring),
       run_asan_test = Single(bool, required=False),
       swarming_extra_args = List(basestring),
       swarming_tags = Set(basestring),
     ),
 
     # Some platforms do not have a 1:1 correlation of BUILD_CONFIG to what is
     # passed as --target on the command line.
@@ skipping 380 matching lines @@
 
 @config_ctx(
     deps=['compiler'], group='memory_tool', includes=['syzyasan_compile_only'])
 def syzyasan(c):
   if c.gyp_env.GYP_DEFINES['component'] != 'static_library':  # pragma: no cover
     raise BadConf('SyzyASan requires component=static_library')
   gyp_defs = c.gyp_env.GYP_DEFINES
   gyp_defs['win_z7'] = 1
   gyp_defs['chromium_win_pch'] = 0
 
-@config_ctx(group='memory_tool')
-def drmemory_full(c):
-  _memory_tool(c, 'drmemory_full')
-  c.gyp_env.GYP_DEFINES['build_for_tool'] = 'drmemory'
-
-@config_ctx(group='memory_tool')
-def drmemory_light(c):
-  _memory_tool(c, 'drmemory_light')
-  c.gyp_env.GYP_DEFINES['build_for_tool'] = 'drmemory'
-
 def _memory_tool(c, tool):

[kjellander_chromium, 2016/10/19 14:09:18]

I suggest we can remove this too.

   if tool not in MEMORY_TOOLS:  # pragma: no cover
     raise BadConf('"%s" is not a supported memory tool, the supported ones '
                   'are: %s' % (tool, ','.join(MEMORY_TOOLS)))
   c.runtests.memory_tool = tool
 
 @config_ctx()
 def lto(c):
   c.lto = True
 
 @config_ctx(includes=['lto'])
@@ skipping 297 matching lines @@
 def cast_linux(c):
   c.gyp_env.GYP_DEFINES['chromecast'] = 1
 
 @config_ctx()
 def internal_gles2_conform_tests(c):
   c.gyp_env.GYP_DEFINES['internal_gles2_conform_tests'] = 1
 
 @config_ctx()
 def build_angle_deqp_tests(c):
   c.gyp_env.GYP_DEFINES['build_angle_deqp_tests'] = 1