Issue 243006: Enables WebCache columns on OS X's task manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243006: Enables WebCache columns on OS X's task manager. (Closed)

Created:
11 years, 2 months ago by jamesr

Modified:
9 years, 6 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Enables WebCache columns on OS X's task manager. TEST=Enabled the Task Manager context menu, opened, enabled columns and observed values that look reasonable. BUG=16221 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27270

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addresses comments #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/task_manager_mac.mm	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jamesr

This patch compiles and follows the pattern of the other columns, but I couldn't verify ...

11 years, 2 months ago (2009-09-25 19:25:29 UTC) #1

Nico

11 years, 2 months ago (2009-09-25 19:43:16 UTC) #2

See http://codereview.chromium.org/208043 for how you can actually test this.

LG, assuming you test this and it works (context-click the table header to
toggle the new columns) and with comments addressed.

http://codereview.chromium.org/243006/diff/1/2
File chrome/browser/cocoa/task_manager_mac.mm (right):

http://codereview.chromium.org/243006/diff/1/2#newcode175
Line 175: return @"";
The windows version doesn't have the IsResourceFirstInGroup() checks for your
new columns. Is there a reason you need them here?

http://codereview.chromium.org/243006/diff/1/2#newcode188
Line 188: return
base::SysWideToNSString(model_->GetResourceWebCoreCSSCacheSize(row));
80col

Expand Messages | Collapse Messages