Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: chrome/browser/cocoa/task_manager_mac.mm

Issue 243006: Enables WebCache columns on OS X's task manager. (Closed)
Patch Set: Addresses comments Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/cocoa/task_manager_mac.h" 5 #include "chrome/browser/cocoa/task_manager_mac.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "app/l10n_util_mac.h" 10 #include "app/l10n_util_mac.h"
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 - (void)setUpTableColumns { 78 - (void)setUpTableColumns {
79 for (NSTableColumn* column in [tableView_ tableColumns]) 79 for (NSTableColumn* column in [tableView_ tableColumns])
80 [tableView_ removeTableColumn:column]; 80 [tableView_ removeTableColumn:column];
81 [self addColumnWithId:IDS_TASK_MANAGER_PAGE_COLUMN visible:YES]; 81 [self addColumnWithId:IDS_TASK_MANAGER_PAGE_COLUMN visible:YES];
82 [self addColumnWithId:IDS_TASK_MANAGER_PHYSICAL_MEM_COLUMN visible:YES]; 82 [self addColumnWithId:IDS_TASK_MANAGER_PHYSICAL_MEM_COLUMN visible:YES];
83 [self addColumnWithId:IDS_TASK_MANAGER_SHARED_MEM_COLUMN visible:NO]; 83 [self addColumnWithId:IDS_TASK_MANAGER_SHARED_MEM_COLUMN visible:NO];
84 [self addColumnWithId:IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN visible:NO]; 84 [self addColumnWithId:IDS_TASK_MANAGER_PRIVATE_MEM_COLUMN visible:NO];
85 [self addColumnWithId:IDS_TASK_MANAGER_CPU_COLUMN visible:YES]; 85 [self addColumnWithId:IDS_TASK_MANAGER_CPU_COLUMN visible:YES];
86 [self addColumnWithId:IDS_TASK_MANAGER_NET_COLUMN visible:YES]; 86 [self addColumnWithId:IDS_TASK_MANAGER_NET_COLUMN visible:YES];
87 [self addColumnWithId:IDS_TASK_MANAGER_PROCESS_ID_COLUMN visible:NO]; 87 [self addColumnWithId:IDS_TASK_MANAGER_PROCESS_ID_COLUMN visible:NO];
88 [self addColumnWithId:IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN
89 visible:NO];
90 [self addColumnWithId:IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN
91 visible:NO];
92 [self addColumnWithId:IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN visible:NO];
88 [self addColumnWithId:IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN visible:NO]; 93 [self addColumnWithId:IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN visible:NO];
89 } 94 }
90 95
91 // Creates a context menu for the table header that allows the user to toggle 96 // Creates a context menu for the table header that allows the user to toggle
92 // which columns should be shown and which should be hidden (like e.g. 97 // which columns should be shown and which should be hidden (like e.g.
93 // Task Manager.app's table header context menu). 98 // Task Manager.app's table header context menu).
94 - (void)setUpTableHeaderContextMenu { 99 - (void)setUpTableHeaderContextMenu {
95 scoped_nsobject<NSMenu> contextMenu( 100 scoped_nsobject<NSMenu> contextMenu(
96 [[NSMenu alloc] initWithTitle:@"Task Manager context menu"]); 101 [[NSMenu alloc] initWithTitle:@"Task Manager context menu"]);
97 for (NSTableColumn* column in [tableView_ tableColumns]) { 102 for (NSTableColumn* column in [tableView_ tableColumns]) {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 return base::SysWideToNSString(model_->GetResourceCPUUsage(row)); 163 return base::SysWideToNSString(model_->GetResourceCPUUsage(row));
159 164
160 case IDS_TASK_MANAGER_NET_COLUMN: // Net 165 case IDS_TASK_MANAGER_NET_COLUMN: // Net
161 return base::SysWideToNSString(model_->GetResourceNetworkUsage(row)); 166 return base::SysWideToNSString(model_->GetResourceNetworkUsage(row));
162 167
163 case IDS_TASK_MANAGER_PROCESS_ID_COLUMN: // Process ID 168 case IDS_TASK_MANAGER_PROCESS_ID_COLUMN: // Process ID
164 if (!model_->IsResourceFirstInGroup(row)) 169 if (!model_->IsResourceFirstInGroup(row))
165 return @""; 170 return @"";
166 return base::SysWideToNSString(model_->GetResourceProcessId(row)); 171 return base::SysWideToNSString(model_->GetResourceProcessId(row));
167 172
173 case IDS_TASK_MANAGER_WEBCORE_IMAGE_CACHE_COLUMN: // WebCore image cache
174 return base::SysWideToNSString(
175 model_->GetResourceWebCoreImageCacheSize(row));
176
177 case IDS_TASK_MANAGER_WEBCORE_SCRIPTS_CACHE_COLUMN: // WebCore script cache
178 return base::SysWideToNSString(
179 model_->GetResourceWebCoreScriptsCacheSize(row));
180
181 case IDS_TASK_MANAGER_WEBCORE_CSS_CACHE_COLUMN: // WebCore CSS cache
182 return base::SysWideToNSString(
183 model_->GetResourceWebCoreCSSCacheSize(row));
184
168 case IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN: // Goats Teleported! 185 case IDS_TASK_MANAGER_GOATS_TELEPORTED_COLUMN: // Goats Teleported!
169 return base::SysWideToNSString(model_->GetResourceGoatsTeleported(row)); 186 return base::SysWideToNSString(model_->GetResourceGoatsTeleported(row));
170 187
171 default: 188 default:
172 return base::SysWideToNSString( 189 return base::SysWideToNSString(
173 model_->GetResourceStatsValue(row, columnId)); 190 model_->GetResourceStatsValue(row, columnId));
174 } 191 }
175 } 192 }
176 193
177 - (id)tableView:(NSTableView*)tableView 194 - (id)tableView:(NSTableView*)tableView
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 void TaskManagerMac::Show() { 245 void TaskManagerMac::Show() {
229 if (instance_) { 246 if (instance_) {
230 // If there's a Task manager window open already, just activate it. 247 // If there's a Task manager window open already, just activate it.
231 [[instance_->window_controller_ window] 248 [[instance_->window_controller_ window]
232 makeKeyAndOrderFront:instance_->window_controller_]; 249 makeKeyAndOrderFront:instance_->window_controller_];
233 } else { 250 } else {
234 instance_ = new TaskManagerMac; 251 instance_ = new TaskManagerMac;
235 instance_->model_->StartUpdating(); 252 instance_->model_->StartUpdating();
236 } 253 }
237 } 254 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698