Use only headless Ozone on Cast audio-only platforms

Use only headless Ozone on Cast audio-only platforms

BUG= internal b/32244773

Committed: https://crrev.com/96fd40efa13fd90a197f301005e222d541456f25
Cr-Commit-Position: refs/heads/master@{#441434}

[kmackay, 2016-10-18 21:37:43]

kmackay@chromium.org changed reviewers:
+ halliwell@chromium.org, slan@chromium.org

[slan, 2016-10-18 21:38:52]

lgtm

[kmackay, 2016-10-18 21:40:43]

kmackay@chromium.org changed reviewers:
+ brettw@chromium.org

[slan, 2016-10-18 21:46:42]

slan@chromium.org changed reviewers:
+ spang@chromium.org

[halliwell, 2016-10-18 21:52:12]

On 2016/10/18 21:46:43, slan wrote:

Just checking, are you pulling in new unwanted dependencies now?
"Enabling this feature disables use of glib, x11, Pango, and Cairo"

The thing I was actually suggesting was to disable building the cast ozone
platform, not ozone altogether.

But if this works for you, lgtm.

[slan, 2016-10-18 22:01:28]

On 2016/10/18 21:52:12, halliwell wrote:
> On 2016/10/18 21:46:43, slan wrote:
> 
> Just checking, are you pulling in new unwanted dependencies now?
> "Enabling this feature disables use of glib, x11, Pango, and Cairo"
> 
> The thing I was actually suggesting was to disable building the cast ozone
> platform, not ozone altogether.
> 
> But if this works for you, lgtm.

Good catch, Luke. No need to turn all these flags on. I like your idea of using
"headless" platform on audio builds.

[kmackay, 2016-10-18 22:06:11]

Description was changed from

==========
Don't use Ozone on Cast audio-only platforms

BUG= internal b/32244773
==========

to

==========
Use only headless Ozone on Cast audio-only platforms

BUG= internal b/32244773
==========

[kmackay, 2016-10-18 22:06:11]

kmackay@chromium.org changed reviewers:
- brettw@chromium.org

[kmackay, 2016-10-18 22:36:58]

The CQ bit was checked by kmackay@chromium.org to run a CQ dry run

[kmackay, 2016-10-18 22:37:15]

On 2016/10/18 22:01:28, slan wrote:
> On 2016/10/18 21:52:12, halliwell wrote:
> > On 2016/10/18 21:46:43, slan wrote:
> > 
> > Just checking, are you pulling in new unwanted dependencies now?
> > "Enabling this feature disables use of glib, x11, Pango, and Cairo"
> > 
> > The thing I was actually suggesting was to disable building the cast ozone
> > platform, not ozone altogether.
> > 
> > But if this works for you, lgtm.
> 
> Good catch, Luke. No need to turn all these flags on. I like your idea of
using
> "headless" platform on audio builds.

Updated, PTAL

[commit-bot: I haz the power, 2016-10-18 22:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[halliwell, 2016-10-18 22:48:56]

On 2016/10/18 22:37:15, kmackay wrote:
> On 2016/10/18 22:01:28, slan wrote:
> > On 2016/10/18 21:52:12, halliwell wrote:
> > > On 2016/10/18 21:46:43, slan wrote:
> > > 
> > > Just checking, are you pulling in new unwanted dependencies now?
> > > "Enabling this feature disables use of glib, x11, Pango, and Cairo"
> > > 
> > > The thing I was actually suggesting was to disable building the cast ozone
> > > platform, not ozone altogether.
> > > 
> > > But if this works for you, lgtm.
> > 
> > Good catch, Luke. No need to turn all these flags on. I like your idea of
> using
> > "headless" platform on audio builds.
> 
> Updated, PTAL

Do you need to update cast_shell_browser_test_filter now?

[commit-bot: I haz the power, 2016-10-18 23:44:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:44:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kmackay, 2016-12-23 18:34:30]

On 2016/10/18 22:48:56, halliwell wrote:
> On 2016/10/18 22:37:15, kmackay wrote:
> > On 2016/10/18 22:01:28, slan wrote:
> > > On 2016/10/18 21:52:12, halliwell wrote:
> > > > On 2016/10/18 21:46:43, slan wrote:
> > > > 
> > > > Just checking, are you pulling in new unwanted dependencies now?
> > > > "Enabling this feature disables use of glib, x11, Pango, and Cairo"
> > > > 
> > > > The thing I was actually suggesting was to disable building the cast
ozone
> > > > platform, not ozone altogether.
> > > > 
> > > > But if this works for you, lgtm.
> > > 
> > > Good catch, Luke. No need to turn all these flags on. I like your idea of
> > using
> > > "headless" platform on audio builds.
> > 
> > Updated, PTAL
> 
> Do you need to update cast_shell_browser_test_filter now?

Done.

[kmackay, 2016-12-23 18:34:50]

The CQ bit was checked by kmackay@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 18:34:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 19:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 19:25:59]

Dry run: This issue passed the CQ dry run.

[kmackay, 2016-12-23 19:59:27]

The CQ bit was checked by kmackay@chromium.org

[kmackay, 2016-12-23 19:59:27]

The patchset sent to the CQ was uploaded after l-g-t-m from slan@chromium.org,
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2429963002/#ps40001
(title: "Fix cast_shell_browsertests args")

[commit-bot: I haz the power, 2016-12-23 19:59:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 20:05:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 20:05:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[spang, 2017-01-04 18:20:31]

The CQ bit was checked by spang@chromium.org

[spang, 2017-01-04 18:20:32]

lgtm

[commit-bot: I haz the power, 2017-01-04 18:20:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 19:27:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483554031383920,
"parent_rev": "8b68d4d53122692c6a2565b9e95eea6b327405fc", "commit_rev":
"784be8929372b9a667f72eb33eaa2d56486e3dbc"}

[commit-bot: I haz the power, 2017-01-04 19:28:03]

Description was changed from

==========
Use only headless Ozone on Cast audio-only platforms

BUG= internal b/32244773
==========

to

==========
Use only headless Ozone on Cast audio-only platforms

BUG= internal b/32244773

Review-Url: https://codereview.chromium.org/2429963002
==========

[commit-bot: I haz the power, 2017-01-04 19:28:04]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-04 19:30:50]

Description was changed from

==========
Use only headless Ozone on Cast audio-only platforms

BUG= internal b/32244773

Review-Url: https://codereview.chromium.org/2429963002
==========

to

==========
Use only headless Ozone on Cast audio-only platforms

BUG= internal b/32244773

Committed: https://crrev.com/96fd40efa13fd90a197f301005e222d541456f25
Cr-Commit-Position: refs/heads/master@{#441434}
==========

[commit-bot: I haz the power, 2017-01-04 19:30:51]

Patchset 3 (id:??) landed as
https://crrev.com/96fd40efa13fd90a197f301005e222d541456f25
Cr-Commit-Position: refs/heads/master@{#441434}