Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2429883002: Revert of libyuv: Set symbol_level=1 for Android builders. (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of libyuv: Set symbol_level=1 for Android builders. (patchset #1 id:1 of https://codereview.chromium.org/2431633002/ ) Reason for revert: The GN command somehow puts symbol_level=2 into the GN args anyway, so this CL just makes things worse (symbol_level being specified twice). Original issue's description: > libyuv: Set symbol_level=1 for Android builders. > > Android 32-bit non-component, non-clang builds cannot have > symbol_level=2 due to 4GiB file size limit, see https://crbug.com/648948 > > BUG=chromium:652188 > TBR=ehmaldonado@chromium.org > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/8063186c66ba88cfed50669b331771266edc863d TBR=ehmaldonado@chromium.org,iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:652188 Committed: https://chromium.googlesource.com/chromium/tools/build/+/e6351d31b52c10d59a56d72e626802c57546805c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M scripts/slave/recipe_modules/libyuv/chromium_config.py View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_x86_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android64_x64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_arm64_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_debug_forced.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android_release.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_arm64.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_rel.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x64.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/libyuv/libyuv.expected/tryserver_libyuv_android_x86.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
kjellander_chromium
Created Revert of libyuv: Set symbol_level=1 for Android builders.
4 years, 2 months ago (2016-10-18 19:11:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429883002/1
4 years, 2 months ago (2016-10-18 19:11:07 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 19:11:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/e6351d31b52c10d59a56...

Powered by Google App Engine
This is Rietveld 408576698