Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: scripts/slave/recipe_modules/libyuv/chromium_config.py

Issue 2429883002: Revert of libyuv: Set symbol_level=1 for Android builders. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_x86_debug.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine.config import BadConf 5 from recipe_engine.config import BadConf
6 6
7 import DEPS 7 import DEPS
8 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX 8 CONFIG_CTX = DEPS['chromium'].CONFIG_CTX
9 from recipe_engine.config_types import Path 9 from recipe_engine.config_types import Path
10 10
(...skipping 12 matching lines...) Expand all
23 23
24 @CONFIG_CTX(includes=['ninja', 'gcc', 'goma']) 24 @CONFIG_CTX(includes=['ninja', 'gcc', 'goma'])
25 def libyuv_gcc(c): 25 def libyuv_gcc(c):
26 _libyuv_common(c) 26 _libyuv_common(c)
27 27
28 @CONFIG_CTX(includes=['android']) 28 @CONFIG_CTX(includes=['android'])
29 def libyuv_android(c): 29 def libyuv_android(c):
30 if c.TARGET_ARCH == 'intel' and c.TARGET_BITS == 32: 30 if c.TARGET_ARCH == 'intel' and c.TARGET_BITS == 32:
31 c.gn_args.append('android_full_debug=true') 31 c.gn_args.append('android_full_debug=true')
32 32
33 # Needs minimal symbols due to 4GB file size limit, see crbug.com/648948.
34 c.gn_args.append('symbol_level=1')
35
36 _libyuv_static_build(c) 33 _libyuv_static_build(c)
37 34
38 @CONFIG_CTX(includes=['android_clang']) 35 @CONFIG_CTX(includes=['android_clang'])
39 def libyuv_android_clang(c): 36 def libyuv_android_clang(c):
40 _libyuv_static_build(c) 37 _libyuv_static_build(c)
41 38
42 @CONFIG_CTX(includes=['chromium', 'static_library']) 39 @CONFIG_CTX(includes=['chromium', 'static_library'])
43 def libyuv_ios(c): 40 def libyuv_ios(c):
44 if c.HOST_PLATFORM != 'mac': 41 if c.HOST_PLATFORM != 'mac':
45 raise BadConf('Only "mac" host platform is supported for iOS (got: "%s")' % 42 raise BadConf('Only "mac" host platform is supported for iOS (got: "%s")' %
(...skipping 11 matching lines...) Expand all
57 def _libyuv_common(c): 54 def _libyuv_common(c):
58 c.compile_py.default_targets = [] 55 c.compile_py.default_targets = []
59 56
60 def _libyuv_static_build(c): 57 def _libyuv_static_build(c):
61 # TODO(kjellander): Investigate moving this into chromium recipe module's 58 # TODO(kjellander): Investigate moving this into chromium recipe module's
62 # static_library config instead. 59 # static_library config instead.
63 if c.BUILD_CONFIG == 'Debug': 60 if c.BUILD_CONFIG == 'Debug':
64 # GN defaults to component builds for Debug, but some build configurations 61 # GN defaults to component builds for Debug, but some build configurations
65 # (Android and iOS) needs it to be static. 62 # (Android and iOS) needs it to be static.
66 c.gn_args.append('is_component_build=false') 63 c.gn_args.append('is_component_build=false')
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/libyuv/libyuv.expected/client_libyuv_android32_x86_debug.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698