[wasm] Compare wasm signatures against SMI constants for more efficient check.

[wasm] Compare wasm signatures against SMI constants for more efficient check.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/7bbfe5c81a1c0470a442074a14cf9e28d5075f45
Cr-Commit-Position: refs/heads/master@{#40403}

[titzer, 2016-10-18 13:02:39]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 13:02:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-10-18 13:08:11]

On 2016/10/18 at 13:02:36, titzer wrote:
> 

It seems like this CL reverts https://codereview.chromium.org/2090923002. Is
this intentional?

[titzer, 2016-10-18 13:12:10]

On 2016/10/18 13:08:11, ahaas wrote:
> On 2016/10/18 at 13:02:36, titzer wrote:
> > 
> 
> It seems like this CL reverts https://codereview.chromium.org/2090923002. Is
> this intentional?

All we need to do is to guarantee that this is a SMI constant and not heap
number.

[titzer, 2016-10-18 13:12:31]

On 2016/10/18 13:12:10, titzer wrote:
> On 2016/10/18 13:08:11, ahaas wrote:
> > On 2016/10/18 at 13:02:36, titzer wrote:
> > > 
> > 
> > It seems like this CL reverts https://codereview.chromium.org/2090923002. Is
> > this intentional?
> 
> All we need to do is to guarantee that this is a SMI constant and not heap
> number.

But you're right, I didn't realize it was a direct revert of the previous CL.

[ahaas, 2016-10-18 13:17:37]

On 2016/10/18 at 13:12:31, titzer wrote:
> On 2016/10/18 13:12:10, titzer wrote:
> > On 2016/10/18 13:08:11, ahaas wrote:
> > > On 2016/10/18 at 13:02:36, titzer wrote:
> > > > 
> > > 
> > > It seems like this CL reverts https://codereview.chromium.org/2090923002.
Is
> > > this intentional?
> > 
> > All we need to do is to guarantee that this is a SMI constant and not heap
> > number.
> 
> But you're right, I didn't realize it was a direct revert of the previous CL.

I think the intention behind the other CL was to enable parallel code
generation. However, since parallel code generation is blocked by the use of the
isolate in the macro assembler, I think we can revert that CL. Therefore lgtm

[commit-bot: I haz the power, 2016-10-18 13:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 13:35:00]

Dry run: This issue passed the CQ dry run.

[titzer, 2016-10-18 13:40:09]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2016-10-18 13:40:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 13:42:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-18 13:43:08]

Description was changed from

==========
[wasm] Compare wasm signatures against SMI constants for more efficient check.

R=ahaas@chromium.org
BUG=
==========

to

==========
[wasm] Compare wasm signatures against SMI constants for more efficient check.

R=ahaas@chromium.org
BUG=

Committed: https://crrev.com/7bbfe5c81a1c0470a442074a14cf9e28d5075f45
Cr-Commit-Position: refs/heads/master@{#40403}
==========

[commit-bot: I haz the power, 2016-10-18 13:43:09]

Patchset 1 (id:??) landed as
https://crrev.com/7bbfe5c81a1c0470a442074a14cf9e28d5075f45
Cr-Commit-Position: refs/heads/master@{#40403}