Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2090923002: [wasm] Use ChangeSmiToInt32 instead of SmiConstant in wasm. (Closed)

Created:
4 years, 6 months ago by ahaas
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use ChangeSmiToInt32 instead of SmiConstant in wasm. Signature indices are encoded as SMIs in the function table of a wasm module. To compare a signature index with the index parameter that is passed to an indirect function call, we now change the signature index to an int32 instead of encoding the index parameter as a SmiConstant. SmiConstants get encoded as NumberConstant nodes in the TF graph, which can cause the allocation of heap numbers. Heap allocation has to be avoided for parallel compilation. R=bradnelson@chromium.org, titzer@chromium.org Committed: https://crrev.com/4b8128a051b6661b13fe9b0e31fb903c0fcf04b6 Cr-Commit-Position: refs/heads/master@{#37240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ahaas
4 years, 6 months ago (2016-06-23 09:28:59 UTC) #1
bradnelson
lgtm
4 years, 6 months ago (2016-06-23 17:40:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090923002/1
4 years, 6 months ago (2016-06-23 17:40:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17900)
4 years, 6 months ago (2016-06-23 17:43:44 UTC) #6
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-24 07:18:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090923002/1
4 years, 6 months ago (2016-06-24 07:19:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 07:21:45 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 07:23:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b8128a051b6661b13fe9b0e31fb903c0fcf04b6
Cr-Commit-Position: refs/heads/master@{#37240}

Powered by Google App Engine
This is Rietveld 408576698