Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: runtime/vm/assembler_arm64.cc

Issue 242983006: Adds load/store from signed unscaled 9-bit offset w/ no writeback. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_arm64.cc
===================================================================
--- runtime/vm/assembler_arm64.cc (revision 35193)
+++ runtime/vm/assembler_arm64.cc (working copy)
@@ -268,8 +268,8 @@
// push it on the stack with PushPP it is tagged again. PopPP then untags
// when restoring from the stack. This will make loading from the object
// pool only one instruction for the first 4096 entries. Otherwise, because
- // the offset wouldn't be aligned, it would always be at least two
- // instructions.
+ // the offset wouldn't be aligned, it would be only one instruction for the
+ // first 64 entries.
sub(pp, pp, Operand(kHeapObjectTag));
}
@@ -559,9 +559,6 @@
ASSERT(base != TMP2);
if (Address::CanHoldOffset(offset)) {
ldr(dest, Address(base, offset));
- } else if (Address::CanHoldOffset(offset, Address::PreIndex)) {
- mov(TMP2, base);
- ldr(dest, Address(TMP2, offset, Address::PreIndex));
} else {
// Since offset is 32-bits, it won't be loaded from the pool.
AddImmediate(TMP2, base, offset, kNoRegister);

Powered by Google App Engine
This is Rietveld 408576698