Handle disabled outputs better when enabling.

Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

Items get added to m_disabledOutputs only from
disableOutputsIfNecessary which happens when the number of connections
goes to 0 or 1, in preparation for collecting the node.  In the test
case, the nodes still have references so there's no call to
disableOutputsIfNecessary.  The output is just disconnected from the
downstream node.

BUG=656652
TEST=audionode-disconnect.html updated to include test

Committed: https://crrev.com/b61db9ee9a2987fa92d5d7aa082b5eaa33684991
Cr-Commit-Position: refs/heads/master@{#425979}

[Raymond Toy, 2016-10-17 19:52:23]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[Raymond Toy, 2016-10-17 19:52:57]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-10-17 19:53:01]

PTAL.

[commit-bot: I haz the power, 2016-10-17 19:53:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-10-17 20:57:38]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[hongchan, 2016-10-17 20:57:51]

lgtm

[commit-bot: I haz the power, 2016-10-17 23:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 23:09:15]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-10-18 15:57:08]

Description was changed from

==========
Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

This happens because when a node is disconnected (and the node still
has a Javascript reference), the output is explicitly disconnected so
it's not put on the m_disabledOutput list.  When the node is then
connected again, all outputs are disabled, removing any outputs from
the m_disabledOutputs list.

BUG=656652
TEST=audionode-disconnect.html updated to include test
==========

to

==========
Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

Items get added to m_disabledOutputs only from disableOutputsIfNecessary which
happens when the number of connections goes to 0 or 1, in preparation for
collecting the node.  In the test case, the nodes still have references so
there's no call to disableOutputsIfNecessary.  The output is just disconnected
from the downstream node.


BUG=656652
TEST=audionode-disconnect.html updated to include test
==========

[Raymond Toy, 2016-10-18 15:57:52]

Description was changed from

==========
Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

Items get added to m_disabledOutputs only from disableOutputsIfNecessary which
happens when the number of connections goes to 0 or 1, in preparation for
collecting the node.  In the test case, the nodes still have references so
there's no call to disableOutputsIfNecessary.  The output is just disconnected
from the downstream node.


BUG=656652
TEST=audionode-disconnect.html updated to include test
==========

to

==========
Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

Items get added to m_disabledOutputs only from
disableOutputsIfNecessary which happens when the number of connections
goes to 0 or 1, in preparation for collecting the node.  In the test
case, the nodes still have references so there's no call to
disableOutputsIfNecessary.  The output is just disconnected from the
downstream node.

BUG=656652
TEST=audionode-disconnect.html updated to include test
==========

[Raymond Toy, 2016-10-18 15:58:01]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-10-18 15:58:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 16:03:40]

Description was changed from

==========
Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

Items get added to m_disabledOutputs only from
disableOutputsIfNecessary which happens when the number of connections
goes to 0 or 1, in preparation for collecting the node.  In the test
case, the nodes still have references so there's no call to
disableOutputsIfNecessary.  The output is just disconnected from the
downstream node.

BUG=656652
TEST=audionode-disconnect.html updated to include test
==========

to

==========
Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

Items get added to m_disabledOutputs only from
disableOutputsIfNecessary which happens when the number of connections
goes to 0 or 1, in preparation for collecting the node.  In the test
case, the nodes still have references so there's no call to
disableOutputsIfNecessary.  The output is just disconnected from the
downstream node.

BUG=656652
TEST=audionode-disconnect.html updated to include test
==========

[commit-bot: I haz the power, 2016-10-18 16:03:42]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-18 16:06:21]

Description was changed from

==========
Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

Items get added to m_disabledOutputs only from
disableOutputsIfNecessary which happens when the number of connections
goes to 0 or 1, in preparation for collecting the node.  In the test
case, the nodes still have references so there's no call to
disableOutputsIfNecessary.  The output is just disconnected from the
downstream node.

BUG=656652
TEST=audionode-disconnect.html updated to include test
==========

to

==========
Handle disabled outputs better when enabling.

The DCHECK for disabled outputs didn't handle the case where
m_disabledOutputs was empty.  Of course, the output isn't in
m_disabledOutputs if m_disabledOutputs is empty.

Items get added to m_disabledOutputs only from
disableOutputsIfNecessary which happens when the number of connections
goes to 0 or 1, in preparation for collecting the node.  In the test
case, the nodes still have references so there's no call to
disableOutputsIfNecessary.  The output is just disconnected from the
downstream node.

BUG=656652
TEST=audionode-disconnect.html updated to include test

Committed: https://crrev.com/b61db9ee9a2987fa92d5d7aa082b5eaa33684991
Cr-Commit-Position: refs/heads/master@{#425979}
==========

[commit-bot: I haz the power, 2016-10-18 16:06:22]

Patchset 1 (id:??) landed as
https://crrev.com/b61db9ee9a2987fa92d5d7aa082b5eaa33684991
Cr-Commit-Position: refs/heads/master@{#425979}