Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/audionode-disconnect.html

Issue 2429633003: Handle disabled outputs better when enabling. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/audionode-disconnect-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/audionode-disconnect.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/audionode-disconnect.html b/third_party/WebKit/LayoutTests/webaudio/audionode-disconnect.html
index 220529a77a4bcd8b16332b3f97bb5104e4a09f14..e9a80628c4cb48252a780117f289ac0707cad4db 100644
--- a/third_party/WebKit/LayoutTests/webaudio/audionode-disconnect.html
+++ b/third_party/WebKit/LayoutTests/webaudio/audionode-disconnect.html
@@ -255,20 +255,29 @@
done();
});
+ audit.defineTask('disabled-outputs', function (taskDone) {
+ // See crbug.com/656652
+ var context = new OfflineAudioContext(2, 1024, 44100);
+ var g1 = context.createGain();
+ var g2 = context.createGain();
+ g1.connect(g2);
+ g1.disconnect(g2);
+ var g3 = context.createGain();
+ g2.connect(g3);
+ g1.connect(g2);
+ context.startRendering().then(function () {
+ // If we make it here, we passed.
+ Should("Disabled outputs handled", true)
+ .summarize("correctly", "inccorrectly");
+ }).then(taskDone);
+ });
+
audit.defineTask('finish', function (done) {
finishJSTest();
done();
});
- audit.runTasks(
- 'disconnect()',
- 'disconnect(output)',
- 'disconnect(AudioNode)',
- 'disconnect(AudioNode, output)',
- 'disconnect(AudioNode, output, input)',
- 'exceptions',
- 'finish'
- );
+ audit.runTasks();
successfullyParsed = true;
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/audionode-disconnect-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698