Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 2429633002: Remap MIME type when loading download items from history db (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Remap MIME type when loading download items from history db Chrome remaps MIME type when inserting download into Android DownloadManager. That allows media file to play properly if they use generic MIME type. However, this doesn't affect the MIME type stored in download history. And when loading the history item into download home, we should do the same thing. TBR=dfalcantara@chromium.org BUG=655901 Review-Url: https://codereview.chromium.org/2423563002 Cr-Commit-Position: refs/heads/master@{#425489} (cherry picked from commit 17963656406b00fd2050bc567e85041cbca3a55c) Committed: https://chromium.googlesource.com/chromium/src/+/1670b4e649db6e170f0e23968fa20d48f0e9bc99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
qinmin
4 years, 2 months ago (2016-10-17 19:36:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1670b4e649db6e170f0e23968fa20d48f0e9bc99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698