Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2423563002: Remap MIME type when loading download items from history db (Closed)

Created:
4 years, 2 months ago by qinmin
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remap MIME type when loading download items from history db Chrome remaps MIME type when inserting download into Android DownloadManager. That allows media file to play properly if they use generic MIME type. However, this doesn't affect the MIME type stored in download history. And when loading the history item into download home, we should do the same thing. BUG=655901 Committed: https://crrev.com/17963656406b00fd2050bc567e85041cbca3a55c Cr-Commit-Position: refs/heads/master@{#425489}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 2 months ago (2016-10-14 20:43:50 UTC) #2
gone
lgtm
4 years, 2 months ago (2016-10-14 20:46:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423563002/1
4 years, 2 months ago (2016-10-14 20:47:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 22:12:34 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 22:15:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17963656406b00fd2050bc567e85041cbca3a55c
Cr-Commit-Position: refs/heads/master@{#425489}

Powered by Google App Engine
This is Rietveld 408576698