Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2429623004: Add performance tests for full frame cycle (Closed)

Created:
4 years, 2 months ago by Xianzhu
Modified:
4 years, 2 months ago
Reviewers:
pdr., wkorman
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add performance tests for full frame cycle They are under paint directory because they mainly test paint + raster performance after style change. Add PerfTestRunner.measureFrameTime(). Committed: https://crrev.com/da92cf5e2403c21b53274775b080d7df20126b79 Cr-Commit-Position: refs/heads/master@{#426216}

Patch Set 1 #

Total comments: 2

Patch Set 2 : - #

Total comments: 2

Patch Set 3 : No random #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -88 lines) Patch
A third_party/WebKit/LayoutTests/fast/harness/perftests/measure-frame-time.html View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/harness/perftests/measure-frame-time-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time-expected.txt View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-background-change-with-invisible-collapsed-borders.html View 2 chunks +13 lines, -40 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Paint/large-table-background-change-with-visible-collapsed-borders.html View 2 chunks +13 lines, -40 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Paint/large-table-collapsed-border-change.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Paint/large-table-collapsed-border-change-with-backgrounds.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Paint/large-table-collapsed-border-change-with-text.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Paint/large-table-repaint.html View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/PerformanceTests/resources/runner.js View 1 5 chunks +33 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Xianzhu
4 years, 2 months ago (2016-10-18 23:19:28 UTC) #2
pdr.
Overall looks pretty good. Do we want to hook this up to run on chromeperf? ...
4 years, 2 months ago (2016-10-18 23:22:08 UTC) #5
Xianzhu
On 2016/10/18 23:22:08, pdr. wrote: > Overall looks pretty good. Do we want to hook ...
4 years, 2 months ago (2016-10-19 03:38:15 UTC) #8
pdr.
LGTM https://codereview.chromium.org/2429623004/diff/20001/third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html File third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html (right): https://codereview.chromium.org/2429623004/diff/20001/third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html#newcode4 third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html:4: var virtualTime = Math.floor(Math.random() * 100000); Nit: could ...
4 years, 2 months ago (2016-10-19 03:50:31 UTC) #9
Xianzhu
https://codereview.chromium.org/2429623004/diff/20001/third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html File third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html (right): https://codereview.chromium.org/2429623004/diff/20001/third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html#newcode4 third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html:4: var virtualTime = Math.floor(Math.random() * 100000); On 2016/10/19 03:50:31, ...
4 years, 2 months ago (2016-10-19 15:17:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429623004/40001
4 years, 2 months ago (2016-10-19 15:18:14 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-19 16:18:43 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:09:11 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/da92cf5e2403c21b53274775b080d7df20126b79
Cr-Commit-Position: refs/heads/master@{#426216}

Powered by Google App Engine
This is Rietveld 408576698