third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html - Issue 2429623004: Add performance tests for full frame cycle

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/harness/perftests/measure-time.html

Issue 2429623004: Add performance tests for full frame cycle (Closed)

Patch Set: - Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <script src="../../../../PerformanceTests/resources/runner.js"></script>

	2 <script>

	3 // The initial value doesn't affect result.

	4 var virtualTime = Math.floor(Math.random() * 100000);
	pdr. 2016/10/19 03:50:31 Nit: could you use a fixed random value like 12345 Nit: could you use a fixed random value like 123456? (here and below) Your current code isn't flaky but I think it's best to be deterministic when possible (e.g., easier to debug if it breaks). Xianzhu 2016/10/19 15:17:10 Done. Show quoted text On 2016/10/19 03:50:31, pdr. wrote: > Nit: could you use a fixed random value like 123456? (here and below) > > Your current code isn't flaky but I think it's best to be deterministic when > possible (e.g., easier to debug if it breaks). Done.
	5 PerfTestRunner.now = function () { return virtualTime; }

	6

	7 var originalSetTimeout = window.setTimeout;

	8 window.setTimeout = function(f, t) {

	9 // This doesn't affect result.

	10 virtualTime += Math.floor(Math.random() * 100000);

	11 originalSetTimeout(f, t);

	12 };

	13

	14 PerfTestRunner.measureTime({

	15 run: function () {

	16 virtualTime += 20;

	17 },

	18 warmUpCount: 3,

	19 doNotMeasureMemoryUsage: true,

	20 });

	21 </script>

OLD	NEW