third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp - Issue 2429343004: [CachedAccessor] for window.document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

Issue 2429343004: [CachedAccessor] for window.document. (Closed)

Patch Set: Fix expectation for global-interface-listing-expected, windows. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

index ce85efcdf7dea8db5599cc889b07dfe5ef1dd715..865447da06afd6001c032b795ed6746876c2bc32 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

@@ -28,7 +28,7 @@ v8::Local<v8::Private> V8PrivateProperty::createV8Private(v8::Isolate* isolate,

isolate, reinterpret_cast<const uint8_t*>(symbol),

v8::NewStringType::kNormal, static_cast<int>(length))

.ToLocalChecked();

- return v8::Private::ForApi(isolate, str);

+ return v8::Private::New(isolate, str);

}

} // namespace blink