Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.cpp

Issue 2429343004: [CachedAccessor] for window.document. (Closed)
Patch Set: Fix expectation for global-interface-listing-expected, windows. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/core/v8/V8PrivateProperty.h" 5 #include "bindings/core/v8/V8PrivateProperty.h"
6 6
7 #include "bindings/core/v8/ScriptState.h" 7 #include "bindings/core/v8/ScriptState.h"
8 #include "bindings/core/v8/ScriptWrappable.h" 8 #include "bindings/core/v8/ScriptWrappable.h"
9 #include "bindings/core/v8/V8Binding.h" 9 #include "bindings/core/v8/V8Binding.h"
10 #include "bindings/core/v8/V8BindingMacros.h" 10 #include "bindings/core/v8/V8BindingMacros.h"
(...skipping 10 matching lines...) Expand all
21 } 21 }
22 22
23 v8::Local<v8::Private> V8PrivateProperty::createV8Private(v8::Isolate* isolate, 23 v8::Local<v8::Private> V8PrivateProperty::createV8Private(v8::Isolate* isolate,
24 const char* symbol, 24 const char* symbol,
25 size_t length) { 25 size_t length) {
26 v8::Local<v8::String> str = 26 v8::Local<v8::String> str =
27 v8::String::NewFromOneByte( 27 v8::String::NewFromOneByte(
28 isolate, reinterpret_cast<const uint8_t*>(symbol), 28 isolate, reinterpret_cast<const uint8_t*>(symbol),
29 v8::NewStringType::kNormal, static_cast<int>(length)) 29 v8::NewStringType::kNormal, static_cast<int>(length))
30 .ToLocalChecked(); 30 .ToLocalChecked();
31 return v8::Private::ForApi(isolate, str); 31 return v8::Private::New(isolate, str);
32 } 32 }
33 33
34 } // namespace blink 34 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698