[CachedAccessor] for window.document.

third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

Index: third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
index 62e15c0abec99387aa47d35f2c33bc03e17e9a69..ba5afcdf97c556101d97fdafd33427e7ae23e34f 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h
@@ -63,6 +63,12 @@ class CORE_EXPORT V8DOMConfiguration final {
     DoNotCheckHolder,
   };
 
+  typedef v8::experimental::FastAccessorBuilder* (*FastAccessorBuilderCallback)(

[haraken, 2016/10/20 08:22:23]

Is this typedef needed?

[vogelheim, 2016/10/20 13:27:59]

Removed.

(That was a leftover from dis-entagling the original mega-CL for several pieces
of functionality.)

+      v8::Isolate*,
+      v8::FunctionCallback);  // Default (slow) callback.
+
+  typedef v8::Local<v8::Private> (*CachedAccessorCallback)(v8::Isolate*);
+
   // AttributeConfiguration translates into calls to SetNativeDataProperty() on
   // either the instance or the prototype ObjectTemplate, based on
   // |instanceOrPrototypeConfiguration|.
@@ -74,6 +80,11 @@ class CORE_EXPORT V8DOMConfiguration final {
     v8::AccessorNameSetterCallback setter;
     v8::AccessorNameGetterCallback getterForMainWorld;
     v8::AccessorNameSetterCallback setterForMainWorld;
+    // TODO(peterssen|vogelheim): This has to be removed too since it's only

[haraken, 2016/10/20 08:22:23]

Remove peterssen (unless he has a plan to work on it)?

[vogelheim, 2016/10/20 13:27:59]

Done.

+    // used in accessors.
+    CachedAccessorCallback cachedAccessorCallback;  // The accessor's 'result'

[haraken, 2016/10/20 08:22:23]

Move up the comment.

[vogelheim, 2016/10/20 13:27:59]

Done.

+                                                    // is stored in a private
+                                                    // property.
     const WrapperTypeInfo* data;
     unsigned settings : 8;             // v8::AccessControl
     unsigned attribute : 8;            // v8::PropertyAttribute
@@ -112,6 +123,9 @@ class CORE_EXPORT V8DOMConfiguration final {
     v8::FunctionCallback setter;
     v8::FunctionCallback getterForMainWorld;
     v8::FunctionCallback setterForMainWorld;
+    CachedAccessorCallback cachedAccessorCallback;  // The accessor's 'result'

[haraken, 2016/10/20 08:22:23]

Ditto.

[vogelheim, 2016/10/20 13:27:59]

Done.

+                                                    // is stored in a private
+                                                    // property.
     const WrapperTypeInfo* data;
     unsigned settings : 8;             // v8::AccessControl
     unsigned attribute : 8;            // v8::PropertyAttribute