[CachedAccessor] for window.document.

third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 45 matching lines @@
     OnInstance = 1 << 0,
     OnPrototype = 1 << 1,
     OnInterface = 1 << 2,
   };
 
   enum HolderCheckConfiguration {
     CheckHolder,
     DoNotCheckHolder,
   };
 
+  typedef v8::experimental::FastAccessorBuilder* (*FastAccessorBuilderCallback)(

[haraken, 2016/10/20 08:22:23]

Is this typedef needed?

[vogelheim, 2016/10/20 13:27:59]

Removed.

(That was a leftover from dis-entagling the original mega-CL for several pieces
of functionality.)

+      v8::Isolate*,
+      v8::FunctionCallback);  // Default (slow) callback.
+
+  typedef v8::Local<v8::Private> (*CachedAccessorCallback)(v8::Isolate*);
+
   // AttributeConfiguration translates into calls to SetNativeDataProperty() on
   // either the instance or the prototype ObjectTemplate, based on
   // |instanceOrPrototypeConfiguration|.
   struct AttributeConfiguration {
     AttributeConfiguration& operator=(const AttributeConfiguration&) = delete;
     DISALLOW_NEW();
     const char* const name;
     v8::AccessorNameGetterCallback getter;
     v8::AccessorNameSetterCallback setter;
     v8::AccessorNameGetterCallback getterForMainWorld;
     v8::AccessorNameSetterCallback setterForMainWorld;
+    // TODO(peterssen|vogelheim): This has to be removed too since it's only

[haraken, 2016/10/20 08:22:23]

Remove peterssen (unless he has a plan to work on it)?

[vogelheim, 2016/10/20 13:27:59]

Done.

+    // used in accessors.
+    CachedAccessorCallback cachedAccessorCallback;  // The accessor's 'result'

[haraken, 2016/10/20 08:22:23]

Move up the comment.

[vogelheim, 2016/10/20 13:27:59]

Done.

+                                                    // is stored in a private
+                                                    // property.
     const WrapperTypeInfo* data;
     unsigned settings : 8;             // v8::AccessControl
     unsigned attribute : 8;            // v8::PropertyAttribute
     unsigned exposeConfiguration : 1;  // ExposeConfiguration
     unsigned
         propertyLocationConfiguration : 3;  // PropertyLocationConfiguration
     unsigned holderCheckConfiguration : 1;  // HolderCheckConfiguration
   };
 
   static void installAttributes(v8::Isolate*,
@@ skipping 18 matching lines @@
   // AccessorConfiguration translates into calls to SetAccessorProperty()
   // on prototype ObjectTemplate.
   struct AccessorConfiguration {
     AccessorConfiguration& operator=(const AccessorConfiguration&) = delete;
     DISALLOW_NEW();
     const char* const name;
     v8::FunctionCallback getter;
     v8::FunctionCallback setter;
     v8::FunctionCallback getterForMainWorld;
     v8::FunctionCallback setterForMainWorld;
+    CachedAccessorCallback cachedAccessorCallback;  // The accessor's 'result'

[haraken, 2016/10/20 08:22:23]

Ditto.

[vogelheim, 2016/10/20 13:27:59]

Done.

+                                                    // is stored in a private
+                                                    // property.
     const WrapperTypeInfo* data;
     unsigned settings : 8;             // v8::AccessControl
     unsigned attribute : 8;            // v8::PropertyAttribute
     unsigned exposeConfiguration : 1;  // ExposeConfiguration
     unsigned
         propertyLocationConfiguration : 3;  // PropertyLocationConfiguration
     unsigned holderCheckConfiguration : 1;  // HolderCheckConfiguration
   };
 
   static void installAccessors(
@@ skipping 167 matching lines @@
   // Sets the class string of platform objects, interface prototype objects,
   // etc.  See also http://heycam.github.io/webidl/#dfn-class-string
   static void setClassString(v8::Isolate*,
                              v8::Local<v8::ObjectTemplate>,
                              const char* classString);
 };
 
 }  // namespace blink
 
 #endif  // V8DOMConfiguration_h