Source/core/css/MediaQueryEvaluator.cpp - Issue 242883002: Remove MediaValues' dependency on RenderStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryEvaluator.cpp

Issue 242883002: Remove MediaValues' dependency on RenderStyle (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modified minimal recalc tests to represent reduced recalc. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaQueryEvaluator.cpp

diff --git a/Source/core/css/MediaQueryEvaluator.cpp b/Source/core/css/MediaQueryEvaluator.cpp

index a3b217793705074828d7ecc8b981047e28ee6c00..67455dec9313f103473b083838d6d8dee923c9a7 100644

--- a/Source/core/css/MediaQueryEvaluator.cpp

+++ b/Source/core/css/MediaQueryEvaluator.cpp

@@ -82,10 +82,10 @@ MediaQueryEvaluator::MediaQueryEvaluator(const char* acceptedMediaType, bool med

{

}

-MediaQueryEvaluator::MediaQueryEvaluator(const String& acceptedMediaType, LocalFrame* frame, RenderStyle* style)

+MediaQueryEvaluator::MediaQueryEvaluator(const String& acceptedMediaType, LocalFrame* frame)

: m_mediaType(acceptedMediaType)

, m_expectedResult(false) // Doesn't matter when we have m_frame and m_style.

- , m_mediaValues(MediaValuesDynamic::create(frame, style))

+ , m_mediaValues(MediaValues::createDynamicIfFrameExists(frame))

{

}