Source/core/css/MediaQueryMatcher.cpp - Issue 242883002: Remove MediaValues' dependency on RenderStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQueryMatcher.cpp

Issue 242883002: Remove MediaValues' dependency on RenderStyle (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Modified minimal recalc tests to represent reduced recalc. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/MediaQueryMatcher.cpp

diff --git a/Source/core/css/MediaQueryMatcher.cpp b/Source/core/css/MediaQueryMatcher.cpp

index bc1f47c665fde6b001f9ae6f6e8371b9cee3045c..9e800403f6304dee257aee5e4564dfdb7c2ad277 100644

--- a/Source/core/css/MediaQueryMatcher.cpp

+++ b/Source/core/css/MediaQueryMatcher.cpp

@@ -77,14 +77,7 @@ PassOwnPtr<MediaQueryEvaluator> MediaQueryMatcher::prepareEvaluator() const

if (!m_document || !m_document->frame())

return nullptr;

- Element* documentElement = m_document->documentElement();

- if (!documentElement)

- return nullptr;

- StyleResolver& styleResolver = m_document->ensureStyleResolver();

- RefPtr<RenderStyle> rootStyle = styleResolver.styleForElement(documentElement, 0 /*defaultParent*/, DisallowStyleSharing, MatchOnlyUserAgentRules);

eseidel 2014/04/19 00:42:15 Yes, you're removing this recalc, so it's not surp

- return adoptPtr(new MediaQueryEvaluator(mediaType(), m_document->frame(), rootStyle.get()));

+ return adoptPtr(new MediaQueryEvaluator(mediaType(), m_document->frame()));

}

bool MediaQueryMatcher::evaluate(const MediaQuerySet* media)

« no previous file with comments | « Source/core/css/MediaQueryEvaluatorTest.cpp ('k') | Source/core/css/MediaValues.h » ('j') | no next file with comments »