third_party/WebKit/Source/web/WebLocalFrameImpl.h - Issue 2428803002: Don't send loading completion callbacks for detaching frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 2428803002: Don't send loading completion callbacks for detaching frames. (Closed)

Patch Set: . Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

index ef0c3886d96745096de37ce65a5aca6fc62604f8..73ee378a7bdbec385cdad61472e8a27f5d65d8c6 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h

@@ -261,8 +261,6 @@ class WEB_EXPORT WebLocalFrameImpl final

WebHistoryLoadType,

bool isClientRedirect) override;

bool isLoading() const override;

- bool isFrameDetachedForSpecialOneOffStopTheCrashingHackBug561873()

- const override;

bool isNavigationScheduledWithin(double interval) const override;

void setCommittedFirstRealLoad() override;

void sendOrientationChangeEvent() override;