Don't send loading completion callbacks for detaching frames.

Don't send loading completion callbacks for detaching frames.

BUG=561873, 595078, 654654
Committed: https://crrev.com/ff60cfffbf14d2419494ffc5fcf544f84dd05aa9
Cr-Commit-Position: refs/heads/master@{#434155}

[dcheng, 2016-10-18 07:15:48]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 07:16:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-18 08:41:43]

Description was changed from

==========
Don't send loading completion callbacks for detaching frames.

BUG=
==========

to

==========
Don't send loading completion callbacks for detaching frames.

BUG=
==========

[dcheng, 2016-10-18 08:41:43]

dcheng@chromium.org changed reviewers:
+ esprehn@chromium.org, kojii@chromium.org

[dcheng, 2016-10-18 08:42:08]

dcheng@chromium.org changed reviewers:
- esprehn@chromium.org, kojii@chromium.org

[commit-bot: I haz the power, 2016-10-18 09:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 09:42:49]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-10-19 19:36:11]

Description was changed from

==========
Don't send loading completion callbacks for detaching frames.

BUG=
==========

to

==========
Don't send loading completion callbacks for detaching frames.

BUG=561873,595078,654654
==========

[dcheng, 2016-10-19 19:36:11]

dcheng@chromium.org changed reviewers:
+ japhet@chromium.org

[dcheng, 2016-10-19 19:36:33]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 19:37:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 21:45:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 21:45:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nate Chapin, 2016-10-21 18:31:45]

lgtm

https://codereview.chromium.org/2428803002/diff/20001/third_party/WebKit/publ...
File third_party/WebKit/public/web/WebLocalFrame.h (left):

https://codereview.chromium.org/2428803002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/web/WebLocalFrame.h:132: virtual bool
isFrameDetachedForSpecialOneOffStopTheCrashingHackBug561873()
That is a fantastic function name.

[esprehn, 2016-10-21 18:35:43]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2016-10-21 18:35:43]

lgtm

[esprehn, 2016-10-24 21:29:42]

Can we land this? :D

[dcheng, 2016-10-24 21:30:49]

On 2016/10/24 21:29:42, esprehn wrote:
> Can we land this? :D

Sorry, I wanted to add a test. Will land once I do that =)

[dcheng, 2016-11-23 01:09:08]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 01:10:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-11-23 01:11:46]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 01:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-11-23 01:13:45]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[dcheng, 2016-11-23 01:14:26]

dcheng@chromium.org changed reviewers:
+ vabr@chromium.org

[dcheng, 2016-11-23 01:14:27]

OK, finally got around to figuring out the test. Interestingly enough, my change
manages to suppress exactly the loading callback that was problematic... and
nothing else.

I've added TODOs to investigate suppressing the other ones as well, but I'd like
to investigate in followups.

+vabr as well for autofill

[commit-bot: I haz the power, 2016-11-23 01:14:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 02:53:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 02:54:00]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-11-23 05:57:36]

dcheng@chromium.org changed reviewers:
+ mkwst@chromium.org

[dcheng, 2016-11-23 05:57:37]

+mkwst, mind sanity checking the Blink-side?

[vabr (Chromium), 2016-11-23 08:21:23]

autofill LGTM, thanks for fixing this!

Vaclav

[Mike West, 2016-11-23 13:00:48]

LGTM, thanks dcheng@!

[dcheng, 2016-11-23 13:06:49]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-11-23 13:06:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/2428803002/#ps100001
(title: "Remove stray include")

[commit-bot: I haz the power, 2016-11-23 13:07:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 13:10:41]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479906409775050,
"parent_rev": "727ab13fc3a440d35dee543f507982c14db95686", "commit_rev":
"98f24b455cc83992211e7b59f0145aabd38f40a3"}

[commit-bot: I haz the power, 2016-11-23 13:11:04]

Description was changed from

==========
Don't send loading completion callbacks for detaching frames.

BUG=561873,595078,654654
==========

to

==========
Don't send loading completion callbacks for detaching frames.

BUG=561873,595078,654654
==========

[commit-bot: I haz the power, 2016-11-23 13:11:05]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-23 13:13:05]

Description was changed from

==========
Don't send loading completion callbacks for detaching frames.

BUG=561873,595078,654654
==========

to

==========
Don't send loading completion callbacks for detaching frames.

BUG=561873,595078,654654

Committed: https://crrev.com/ff60cfffbf14d2419494ffc5fcf544f84dd05aa9
Cr-Commit-Position: refs/heads/master@{#434155}
==========

[commit-bot: I haz the power, 2016-11-23 13:13:07]

Patchset 6 (id:??) landed as
https://crrev.com/ff60cfffbf14d2419494ffc5fcf544f84dd05aa9
Cr-Commit-Position: refs/heads/master@{#434155}

[kojii, 2016-11-23 14:42:29]

Thank you so much, dcheng@!