Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2428773004: Add tests showing using LocalElementBuilder separately, for variable or body. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests showing using LocalElementBuilder separately, for variable or body. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/412cceb7d0505ccb8d90b8542128f5220414c6c6

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add documentation for build*Initializer() methods. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -98 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 5 chunks +50 lines, -41 lines 0 comments Download
M pkg/analyzer/test/dart/element/builder_test.dart View 4 chunks +161 lines, -57 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 2 months ago (2016-10-18 21:09:31 UTC) #1
Paul Berry
lgtm https://codereview.chromium.org/2428773004/diff/1/pkg/analyzer/lib/src/dart/element/builder.dart File pkg/analyzer/lib/src/dart/element/builder.dart (right): https://codereview.chromium.org/2428773004/diff/1/pkg/analyzer/lib/src/dart/element/builder.dart#newcode1318 pkg/analyzer/lib/src/dart/element/builder.dart:1318: void buildParameterInitializer( Since this method is now public, ...
4 years, 2 months ago (2016-10-18 21:14:09 UTC) #2
scheglov
https://codereview.chromium.org/2428773004/diff/1/pkg/analyzer/lib/src/dart/element/builder.dart File pkg/analyzer/lib/src/dart/element/builder.dart (right): https://codereview.chromium.org/2428773004/diff/1/pkg/analyzer/lib/src/dart/element/builder.dart#newcode1318 pkg/analyzer/lib/src/dart/element/builder.dart:1318: void buildParameterInitializer( On 2016/10/18 21:14:09, Paul Berry wrote: > ...
4 years, 2 months ago (2016-10-18 21:18:38 UTC) #3
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-18 21:23:43 UTC) #4
scheglov
4 years, 2 months ago (2016-10-18 21:38:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
412cceb7d0505ccb8d90b8542128f5220414c6c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698