Add tests showing using LocalElementBuilder separately, for variable or body.

pkg/analyzer/lib/src/dart/element/builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.dart.element.builder;
 
 import 'dart:collection';
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
@@ skipping 1023 matching lines @@
 
   @override
   Object visitBlockFunctionBody(BlockFunctionBody node) {
     _buildLocal(node);
     return null;
   }
 
   @override
   Object visitDefaultFormalParameter(DefaultFormalParameter node) {
     super.visitDefaultFormalParameter(node);
-    _buildParameterInitializer(node.element as ParameterElementImpl, node);
+    buildParameterInitializer(
+        node.element as ParameterElementImpl, node.defaultValue);
     return null;
   }
 
   @override
   Object visitExpressionFunctionBody(ExpressionFunctionBody node) {
     _buildLocal(node);
     return null;
   }
 
   @override
   Object visitVariableDeclaration(VariableDeclaration node) {
     super.visitVariableDeclaration(node);
     VariableElementImpl element = node.element as VariableElementImpl;
-    _buildVariableInitializer(element, node.initializer);
+    buildVariableInitializer(element, node.initializer);
     return null;
   }
 
   void _buildLocal(AstNode node) {
     node.accept(new LocalElementBuilder(_currentHolder, _unitElement));
   }
 }
 
 /**
  * Traverse a [FunctionBody] and build elements for AST structures.
@@ skipping 195 matching lines @@
     } else {
       element = new LocalVariableElementImpl.forNode(variableName);
     }
     _setCodeRange(element, node);
     _setVariableVisibleRange(element, node);
     element.hasImplicitType = varList.type == null;
     _currentHolder.addLocalVariable(element);
     variableName.staticElement = element;
     element.const3 = isConst;
     element.final2 = isFinal;
-    _buildVariableInitializer(element, initializerNode);
+    buildVariableInitializer(element, initializerNode);
     return null;
   }
 
   @override
   Object visitVariableDeclarationList(VariableDeclarationList node) {
     super.visitVariableDeclarationList(node);
     List<ElementAnnotation> elementAnnotations =
         _createElementAnnotations(node.metadata);
     _setVariableDeclarationListAnnotations(node, elementAnnotations);
     return null;
@@ skipping 22 matching lines @@
    */
   final CompilationUnitElementImpl _unitElement;
 
   /**
    * The element holder associated with the element that is currently being built.
    */
   ElementHolder _currentHolder;
 
   _BaseElementBuilder(this._currentHolder, this._unitElement);
 
+  void buildParameterInitializer(

[Paul Berry, 2016/10/18 21:14:09]

Since this method is now public, would you mind adding doc comments?

[scheglov, 2016/10/18 21:18:38]

Done.

+      ParameterElementImpl parameter, Expression defaultValue) {
+    if (defaultValue != null) {
+      ElementHolder holder = new ElementHolder();
+      _visit(holder, defaultValue);
+      FunctionElementImpl initializer =
+          new FunctionElementImpl.forOffset(defaultValue.beginToken.offset);
+      initializer.hasImplicitReturnType = true;
+      initializer.functions = holder.functions;
+      initializer.labels = holder.labels;
+      initializer.localVariables = holder.localVariables;
+      initializer.parameters = holder.parameters;
+      initializer.synthetic = true;
+      initializer.type = new FunctionTypeImpl(initializer);
+      parameter.initializer = initializer;
+      parameter.defaultValueCode = defaultValue.toSource();
+      holder.validate();
+    }
+  }
+
+  void buildVariableInitializer(VariableElementImpl element, Expression node) {

[Paul Berry, 2016/10/18 21:14:09]

Same here.

+    if (node != null) {
+      ElementHolder holder = new ElementHolder();
+      _visit(holder, node);
+      FunctionElementImpl initializer =
+          new FunctionElementImpl.forOffset(node.beginToken.offset);
+      initializer.hasImplicitReturnType = true;
+      initializer.functions = holder.functions;
+      initializer.labels = holder.labels;
+      initializer.localVariables = holder.localVariables;
+      initializer.synthetic = true;
+      initializer.type = new FunctionTypeImpl(initializer);
+      element.initializer = initializer;
+      holder.validate();
+    }
+  }
+
   @override
   Object visitDefaultFormalParameter(DefaultFormalParameter node) {
     NormalFormalParameter normalParameter = node.parameter;
     SimpleIdentifier parameterName = normalParameter.identifier;
     ParameterElementImpl parameter;
     if (normalParameter is FieldFormalParameter) {
       DefaultFieldFormalParameterElementImpl fieldParameter =
           new DefaultFieldFormalParameterElementImpl.forNode(parameterName);
       _setFieldParameterField(fieldParameter);
       parameter = fieldParameter;
@@ skipping 73 matching lines @@
     _setCodeRange(typeParameter, node);
     typeParameter.metadata = _createElementAnnotations(node.metadata);
     TypeParameterTypeImpl typeParameterType =
         new TypeParameterTypeImpl(typeParameter);
     typeParameter.type = typeParameterType;
     _currentHolder.addTypeParameter(typeParameter);
     parameterName.staticElement = typeParameter;
     return super.visitTypeParameter(node);
   }
 
-  void _buildParameterInitializer(
-      ParameterElementImpl parameter, DefaultFormalParameter node) {
-    Expression defaultValue = node.defaultValue;
-    if (defaultValue != null) {
-      ElementHolder holder = new ElementHolder();
-      _visit(holder, defaultValue);
-      FunctionElementImpl initializer =
-          new FunctionElementImpl.forOffset(defaultValue.beginToken.offset);
-      initializer.hasImplicitReturnType = true;
-      initializer.functions = holder.functions;
-      initializer.labels = holder.labels;
-      initializer.localVariables = holder.localVariables;
-      initializer.parameters = holder.parameters;
-      initializer.synthetic = true;
-      initializer.type = new FunctionTypeImpl(initializer);
-      parameter.initializer = initializer;
-      parameter.defaultValueCode = defaultValue.toSource();
-      holder.validate();
-    }
-  }
-
-  void _buildVariableInitializer(VariableElementImpl element, Expression node) {
-    if (node != null) {
-      ElementHolder holder = new ElementHolder();
-      _visit(holder, node);
-      FunctionElementImpl initializer =
-          new FunctionElementImpl.forOffset(node.beginToken.offset);
-      initializer.hasImplicitReturnType = true;
-      initializer.functions = holder.functions;
-      initializer.labels = holder.labels;
-      initializer.localVariables = holder.localVariables;
-      initializer.synthetic = true;
-      initializer.type = new FunctionTypeImpl(initializer);
-      element.initializer = initializer;
-      holder.validate();
-    }
-  }
-
   /**
    * For each [Annotation] found in [annotations], create a new
    * [ElementAnnotation] object and set the [Annotation] to point to it.
    */
   List<ElementAnnotation> _createElementAnnotations(
       NodeList<Annotation> annotations) {
     if (annotations.isEmpty) {
       return ElementAnnotation.EMPTY_LIST;
     }
     return annotations.map((Annotation a) {
@@ skipping 134 matching lines @@
     return null;
   }
 
   /**
    * Return the lexical identifiers associated with the given [identifiers].
    */
   static List<String> _getIdentifiers(NodeList<SimpleIdentifier> identifiers) {
     return identifiers.map((identifier) => identifier.name).toList();
   }
 }