Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: net/quic/core/quic_framer_test.cc

Issue 2428623002: Deprecate FLAGS_quic_packet_numbers_largest_received. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_framer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_framer_test.cc
diff --git a/net/quic/core/quic_framer_test.cc b/net/quic/core/quic_framer_test.cc
index cd43369c91ee00888cce0c74065d1c423d3799ae..9de89ab2d48fe10b45f9b3a1c9077812a886a902 100644
--- a/net/quic/core/quic_framer_test.cc
+++ b/net/quic/core/quic_framer_test.cc
@@ -1187,11 +1187,7 @@ TEST_P(QuicFramerTest, ReceivedPacketOnClosedPath) {
}
TEST_P(QuicFramerTest, PacketHeaderWith4BytePacketNumber) {
- if (FLAGS_quic_packet_numbers_largest_received) {
- QuicFramerPeer::SetLargestPacketNumber(&framer_, kPacketNumber - 2);
- } else {
- QuicFramerPeer::SetLastPacketNumber(&framer_, kPacketNumber - 2);
- }
+ QuicFramerPeer::SetLargestPacketNumber(&framer_, kPacketNumber - 2);
// clang-format off
unsigned char packet[] = {
@@ -1261,11 +1257,7 @@ TEST_P(QuicFramerTest, PacketHeaderWith4BytePacketNumber) {
}
TEST_P(QuicFramerTest, PacketHeaderWith2BytePacketNumber) {
- if (FLAGS_quic_packet_numbers_largest_received) {
- QuicFramerPeer::SetLargestPacketNumber(&framer_, kPacketNumber - 2);
- } else {
- QuicFramerPeer::SetLastPacketNumber(&framer_, kPacketNumber - 2);
- }
+ QuicFramerPeer::SetLargestPacketNumber(&framer_, kPacketNumber - 2);
// clang-format off
unsigned char packet[] = {
@@ -1337,11 +1329,7 @@ TEST_P(QuicFramerTest, PacketHeaderWith2BytePacketNumber) {
}
TEST_P(QuicFramerTest, PacketHeaderWith1BytePacketNumber) {
- if (FLAGS_quic_packet_numbers_largest_received) {
- QuicFramerPeer::SetLargestPacketNumber(&framer_, kPacketNumber - 2);
- } else {
- QuicFramerPeer::SetLastPacketNumber(&framer_, kPacketNumber - 2);
- }
+ QuicFramerPeer::SetLargestPacketNumber(&framer_, kPacketNumber - 2);
// clang-format off
unsigned char packet[] = {
@@ -1413,7 +1401,6 @@ TEST_P(QuicFramerTest, PacketHeaderWith1BytePacketNumber) {
}
TEST_P(QuicFramerTest, PacketNumberDecreasesThenIncreases) {
- FLAGS_quic_packet_numbers_largest_received = true;
// Test the case when a packet is received from the past and future packet
// numbers are still calculated relative to the largest received packet.
QuicPacketHeader header;
« no previous file with comments | « net/quic/core/quic_framer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698