Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: net/quic/core/quic_framer.cc

Issue 2428623002: Deprecate FLAGS_quic_packet_numbers_largest_received. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_framer.h ('k') | net/quic/core/quic_framer_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_framer.cc
diff --git a/net/quic/core/quic_framer.cc b/net/quic/core/quic_framer.cc
index 6111e8d18407a01a9cf6eecc075bef28667a53ba..ef3600d75f43b4c87d592117acdfe6cf23b63aa3 100644
--- a/net/quic/core/quic_framer.cc
+++ b/net/quic/core/quic_framer.cc
@@ -803,28 +803,15 @@ bool QuicFramer::IsValidPath(QuicPathId path_id,
return false;
}
- if (FLAGS_quic_packet_numbers_largest_received) {
- if (path_id == last_path_id_) {
- *base_packet_number = largest_packet_number_;
- return true;
- }
+ if (path_id == last_path_id_) {
+ *base_packet_number = largest_packet_number_;
+ return true;
+ }
- if (ContainsKey(largest_packet_numbers_, path_id)) {
- *base_packet_number = largest_packet_numbers_[path_id];
- } else {
- *base_packet_number = 0;
- }
+ if (ContainsKey(largest_packet_numbers_, path_id)) {
+ *base_packet_number = largest_packet_numbers_[path_id];
} else {
- if (path_id == last_path_id_) {
- *base_packet_number = last_packet_number_;
- return true;
- }
-
- if (ContainsKey(last_packet_numbers_, path_id)) {
- *base_packet_number = last_packet_numbers_[path_id];
- } else {
- *base_packet_number = 0;
- }
+ *base_packet_number = 0;
}
return true;
@@ -834,23 +821,18 @@ void QuicFramer::SetLastPacketNumber(const QuicPacketHeader& header) {
if (header.public_header.multipath_flag && header.path_id != last_path_id_) {
if (last_path_id_ != kInvalidPathId) {
// Save current last packet number before changing path.
- last_packet_numbers_[last_path_id_] = last_packet_number_;
- if (FLAGS_quic_packet_numbers_largest_received) {
- largest_packet_numbers_[last_path_id_] = largest_packet_number_;
- }
+ largest_packet_numbers_[last_path_id_] = largest_packet_number_;
}
// Change path.
last_path_id_ = header.path_id;
}
last_packet_number_ = header.packet_number;
- if (FLAGS_quic_packet_numbers_largest_received) {
- largest_packet_number_ = max(header.packet_number, largest_packet_number_);
- }
+ largest_packet_number_ = max(header.packet_number, largest_packet_number_);
}
void QuicFramer::OnPathClosed(QuicPathId path_id) {
closed_paths_.insert(path_id);
- last_packet_numbers_.erase(path_id);
+ largest_packet_numbers_.erase(path_id);
}
QuicPacketNumber QuicFramer::CalculatePacketNumberFromWire(
@@ -1068,9 +1050,7 @@ bool QuicFramer::ProcessUnauthenticatedHeader(QuicDataReader* encrypted_reader,
return RaiseError(QUIC_INVALID_PACKET_HEADER);
}
- QuicPacketNumber base_packet_number =
- FLAGS_quic_packet_numbers_largest_received ? largest_packet_number_
- : last_packet_number_;
+ QuicPacketNumber base_packet_number = largest_packet_number_;
if (header->public_header.multipath_flag &&
!IsValidPath(header->path_id, &base_packet_number)) {
// Stop processing because path is closed.
« no previous file with comments | « net/quic/core/quic_framer.h ('k') | net/quic/core/quic_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698