Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2819)

Issue 2428603002: Add a buildbotless Android bot (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
dogben, borenet
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Make it a GPU job #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -1 line) Patch
M infra/bots/gen_tasks.go View 1 3 chunks +11 lines, -1 line 2 comments Download
M infra/bots/tasks.json View 1 4 chunks +125 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
borenet
4 years, 2 months ago (2016-10-17 16:09:55 UTC) #3
mtklein
*\o/*
4 years, 2 months ago (2016-10-17 16:32:02 UTC) #5
dogben
lgtm https://codereview.chromium.org/2428603002/diff/20001/infra/bots/gen_tasks.go File infra/bots/gen_tasks.go (right): https://codereview.chromium.org/2428603002/diff/20001/infra/bots/gen_tasks.go#newcode485 infra/bots/gen_tasks.go:485: if parts["role"] != "Housekeeper" { Should this just ...
4 years, 2 months ago (2016-10-17 16:32:31 UTC) #7
borenet
https://codereview.chromium.org/2428603002/diff/20001/infra/bots/gen_tasks.go File infra/bots/gen_tasks.go (right): https://codereview.chromium.org/2428603002/diff/20001/infra/bots/gen_tasks.go#newcode485 infra/bots/gen_tasks.go:485: if parts["role"] != "Housekeeper" { On 2016/10/17 16:32:31, dogben ...
4 years, 2 months ago (2016-10-17 16:51:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428603002/20001
4 years, 2 months ago (2016-10-17 16:52:22 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 17:17:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5238343ab27a9f42983b6c79f199416a5ae58542

Powered by Google App Engine
This is Rietveld 408576698