Add a buildbotless Android bot

infra/bots/gen_tasks.go

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package main
 
 /*
         Generate the tasks.json file.
 */
 
@@ skipping 25 matching lines @@
         PREFIX_UPLOAD = "Upload"
 )
 
 var (
         // "Constants"
 
         // Top-level list of all jobs to run at each commit.
         JOBS = []string{
                 "Build-Ubuntu-GCC-x86_64-Release-GN",
                 "Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN",
+                "Test-Android-Clang-AndroidOne-GPU-Mali400MP2-arm-Release-GN_Android",
                 "Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-GN",
                 "Housekeeper-PerCommit-InfraTests",
         }
 
         // UPLOAD_DIMENSIONS are the Swarming dimensions for upload tasks.
         UPLOAD_DIMENSIONS = []string{
                 "cpu:x86-64-avx2",
                 "gpu:none",
                 "os:Ubuntu",
                 fmt.Sprintf("pool:%s", POOL_SKIA),
@@ skipping 20 matching lines @@
                 return "Build-Ubuntu-GCC-x86_64-Release-Shared"
         } else if parts["role"] == "Test" || parts["role"] == "Perf" {
                 task_os := parts["os"]
                 ec := parts["extra_config"]
                 if task_os == "Android" {
                         if ec == "Vulkan" {
                                 ec = "Android_Vulkan"
                         } else if !strings.Contains(ec, "GN_Android") {
                                 ec = task_os
                         }
-                        task_os = "Android"
+                        task_os = "Ubuntu"
                 } else if task_os == "iOS" {
                         ec = task_os
                         task_os = "Mac"
                 } else if strings.Contains(task_os, "Win") {
                         task_os = "Win"
                 }
                 name, err := jobNameSchema.MakeJobName(map[string]string{
                         "role":          "Build",
                         "os":            task_os,
                         "compiler":      parts["compiler"],
@@ skipping 371 matching lines @@
                 deps = append(deps, infra(cfg, name))
         }
 
         // Compile bots.
         if parts["role"] == "Build" {
                 deps = append(deps, compile(cfg, name, parts))
         }
 
         // Any remaining bots need a compile task.
         compileTaskName := deriveCompileTaskName(name, parts)
+        compileTaskParts, err := jobNameSchema.ParseJobName(compileTaskName)
+        if err != nil {
+                glog.Fatal(err)
+        }
+        // Temporarily disable the Housekeeper's compile Task, since we aren't
+        // yet running that Job.
+        if parts["role"] != "Housekeeper" {

[dogben, 2016/10/17 16:32:31]

Should this just be name != "Housekeeper-PerCommit-InfraTests" and can be
permanent?

Alternatively, should test(), perf(), and housekeeper() be the ones to call
compile()?

[borenet, 2016/10/17 16:51:03]

So we need this if-statement just to prevent us from creating an orphaned
compile task for the Housekeeper-PerCommit bot, which doesn't yet exist.  Once
we add that bot, we can remove this and everything works fine.  As for moving
the call to compile, I'm fine with that in the long run, but for now I'd like to
match the flow in the swarm_trigger recipe as closely as possible.

+                compile(cfg, compileTaskName, compileTaskParts)
+        }
 
         // Housekeeper.
         if parts["role"] == "Housekeeper" && name != "Housekeeper-PerCommit-InfraTests" {
                 deps = append(deps, housekeeper(cfg, name, compileTaskName))
         }
 
         // Common assets needed by the remaining bots.
         pkgs := []*specs.CipdPackage{
                 getCipdPackage("skimage"),
                 getCipdPackage("skp"),
@@ skipping 171 matching lines @@
                 if !ok {
                         return "", fmt.Errorf("Invalid job parts; missing %q", k)
                 }
                 rvParts = append(rvParts, v)
         }
         if _, ok := parts["extra_config"]; ok {
                 rvParts = append(rvParts, parts["extra_config"])
         }
         return strings.Join(rvParts, s.Sep), nil
 }