Simplify should-eager-compile handling

Simplify should-eager-compile handling

BUG=v8:5209
Committed: https://crrev.com/7b5f018a2d4931c408d6111015480a960f386e76
Cr-Commit-Position: refs/heads/master@{#40366}

[Toon Verwaest, 2016-10-17 11:04:08]

verwaest@chromium.org changed reviewers:
+ jochen@chromium.org

[Toon Verwaest, 2016-10-17 11:04:09]

ptal

[jochen (gone - plz use gerrit), 2016-10-17 11:23:37]

https://codereview.chromium.org/2428533002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2428533002/diff/1/src/ast/scopes.cc#newcode317
src/ast/scopes.cc:317: should_eager_compile_ = !is_lazily_parsed_;
when is is_lazily_parsed_ true here?

[Toon Verwaest, 2016-10-17 11:28:35]

https://codereview.chromium.org/2428533002/diff/1/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2428533002/diff/1/src/ast/scopes.cc#newcode317
src/ast/scopes.cc:317: should_eager_compile_ = !is_lazily_parsed_;
On 2016/10/17 11:23:37, jochen wrote:
> when is is_lazily_parsed_ true here?

If we preparsed the function for example. E.g.,:

!function(){}() at the toplevel will try to set_should_eager_compile due to the
() at the end, but we will have preparsed the function, so we can't make it be
eagerly compiled. In the future, hopefully it will be true as well for all inner
function of a ParseFunction job, since we will have preparsed them all already,
and will just skip over it in O(1).

[jochen (gone - plz use gerrit), 2016-10-17 13:43:57]

lgtm

[Toon Verwaest, 2016-10-17 13:47:07]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-10-17 13:47:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 14:11:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-17 14:11:46]

Description was changed from

==========
Simplify should-eager-compile handling

BUG=v8:5209
==========

to

==========
Simplify should-eager-compile handling

BUG=v8:5209

Committed: https://crrev.com/7b5f018a2d4931c408d6111015480a960f386e76
Cr-Commit-Position: refs/heads/master@{#40366}
==========

[commit-bot: I haz the power, 2016-10-17 14:11:47]

Patchset 1 (id:??) landed as
https://crrev.com/7b5f018a2d4931c408d6111015480a960f386e76
Cr-Commit-Position: refs/heads/master@{#40366}