Simplify should-eager-compile handling

src/ast/scopes.cc

Index: src/ast/scopes.cc
diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc
index ae5d972a72f9d326ca6e6a96aed4dd311ebc8ca6..55fd739d62a95c26f4e5dc8181ffd3636aa889de 100644
--- a/src/ast/scopes.cc
+++ b/src/ast/scopes.cc
@@ -310,12 +310,11 @@ bool Scope::HasSimpleParameters() {
 }
 
 bool DeclarationScope::ShouldEagerCompile() const {
-  if (!AllowsLazyCompilation()) return true;
-  return !is_lazily_parsed_ && should_eager_compile_;
+  return force_eager_compilation_ || should_eager_compile_;
 }
 
 void DeclarationScope::set_should_eager_compile() {
-  should_eager_compile_ = true;
+  should_eager_compile_ = !is_lazily_parsed_;

[jochen (gone - plz use gerrit), 2016/10/17 11:23:37]

when is is_lazily_parsed_ true here?

[Toon Verwaest, 2016/10/17 11:28:35]

If we preparsed the function for example. E.g.,:

!function(){}() at the toplevel will try to set_should_eager_compile due to the
() at the end, but we will have preparsed the function, so we can't make it be
eagerly compiled. In the future, hopefully it will be true as well for all inner
function of a ParseFunction job, since we will have preparsed them all already,
and will just skip over it in O(1).

 }
 
 void DeclarationScope::set_asm_module() {