Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2428413003: Mark some other instances of visibleLength/visibleOffset as informative. (Closed)

Created:
4 years, 2 months ago by Paul Berry
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, vsm
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark some other instances of visibleLength/visibleOffset as informative. These were inadvertenly left out of 84ec7f01c060ee0a5e423c58a11707a4e3a60045. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/105f568452fa562207ce6fbc557bb7638024cc69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 2 months ago (2016-10-19 22:31:36 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-19 22:34:26 UTC) #3
Paul Berry
4 years, 2 months ago (2016-10-20 16:09:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
105f568452fa562207ce6fbc557bb7638024cc69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698